[Fix/727] Change location for get angular application configuration #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
approved these changes
Jul 21, 2024
|
Thank I will merge and release tomorrow. |
ia3andy
requested changes
Jul 22, 2024
...ment/src/main/java/io/quarkiverse/quinoa/deployment/framework/override/AngularFramework.java
Outdated
Show resolved
Hide resolved
ia3andy
approved these changes
Jul 22, 2024
|
@melloware, issue #723 will be fixed by this correction because if custom build-dir is provided then, I don't do anything. But I don't understand why if custom uiDir is provided, angular.json file is not found. I am checking that point. |
|
This PR fix #723 issue. Because if ui-dir is provided in configuration, in this version we don't get angular.json file. |
melloware
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I have changed the detection of angular configuration application. Before we used the package.json's name. Now we get the application available in angular.json file. If multiple applications exist in this configuration, an exception will be thrown. Users have to help quinoa to know which one must be build in this context.
Fixes Issue
closes #721
Fix #723
Check List (Check all the applicable boxes)