Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump quarkus.version from 3.8.3 to 3.9.1 #363

Merged
merged 7 commits into from
Mar 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven-regression.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
quarkus-version: [ "3.0", "3.1", "3.2", "3.3", "3.4", "3.5", "3.6", "3.7" ]
quarkus-version: [ "3.0", "3.1", "3.2", "3.3", "3.4", "3.5", "3.6", "3.7", "3.8" ]
json-provider: [ "jsonb-classic", "jackson-classic" ]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/native-mode-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ jobs:

- uses: graalvm/setup-graalvm@v1
with:
version: '22.3.1'
java-version: '17'
distribution: 'graalvm'
components: 'native-image'
github-token: ${{ secrets.GITHUB_TOKEN }}

Expand Down
20 changes: 13 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
This extension supports:
- Quarkus 1, 2 and 3
- `quarkus-resteasy-jackson` and `quarkus-resteasy-jsonb`
- `quarkus-resteasy-reactive-jackson` and `quarkus-resteasy-reactive-jsonb`
- `quarkus-rest-jackson` and `quarkus-rest-jsonb`
- JVM and native mode

## Why you should use this extension?
Expand All @@ -48,24 +48,30 @@ so-called "HTTP APIs" are usually not.
```

## Usage
### Quarkus 3.X / Java 17+
Make sure JDK 17 is in your PATH, then run:
### Quarkus 3.X
Quarkus | Java | quarkus-resteasy-problem
---------------------|------|-------------------------
< 3.7.0 | 11+ | 3.1.0
\>= 3.7.0 && < 3.9.0 | 17+ | 3.7.0
\>= 3.9.0 | 17+ | 3.9.0

Make sure proper version of JDK (look for the table above), then run:
```shell
mvn io.quarkus:quarkus-maven-plugin:3.8.3:create \
mvn io.quarkus:quarkus-maven-plugin:${quarkus.version}:create \
-DprojectGroupId=problem \
-DprojectArtifactId=quarkus-resteasy-problem-playground \
-DclassName="problem.HelloResource" \
-Dpath="/hello" \
-Dextensions="resteasy,resteasy-jackson"
cd quarkus-resteasy-problem-playground
./mvnw quarkus:add-extension -Dextensions="com.tietoevry.quarkus:quarkus-resteasy-problem:3.1.0"
./mvnw quarkus:add-extension -Dextensions="com.tietoevry.quarkus:quarkus-resteasy-problem:${quarkus-resteasy-problem.version}"
```
Or add the following dependency to `pom.xml` in existing project:
```xml
<dependency>
<groupId>com.tietoevry.quarkus</groupId>
<artifactId>quarkus-resteasy-problem</artifactId>
<version>3.1.0</version>
<version>3.9.0</version>
</dependency>
```

Expand Down Expand Up @@ -116,7 +122,7 @@ Or add the following dependency to `pom.xml` in existing project:
```
</details>

**Hint:** you can also use `resteasy-jsonb` or reactive equivalents: `resteasy-reactive-jackson` / `resteasy-reactive-jsonb` instead of `resteasy-jackson`
**Hint:** you can also use `resteasy-jsonb` or reactive equivalents: `rest-jackson` / `rest-jsonb` instead of `resteasy-jackson`


Once you run Quarkus: `./mvnw compile quarkus:dev`, and you will find `resteasy-problem` in the logs:
Expand Down
2 changes: 1 addition & 1 deletion deployment/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy-reactive-spi-deployment</artifactId>
<artifactId>quarkus-rest-spi-deployment</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
Expand Down
11 changes: 9 additions & 2 deletions integration-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<dependencies>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy-reactive-jackson</artifactId>
<artifactId>quarkus-rest-jackson</artifactId>
</dependency>
</dependencies>
</profile>
Expand All @@ -147,7 +147,7 @@
<dependencies>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy-reactive-jsonb</artifactId>
<artifactId>quarkus-rest-jsonb</artifactId>
</dependency>
</dependencies>
</profile>
Expand Down Expand Up @@ -204,6 +204,13 @@
</properties>
</profile>

<profile>
<id>quarkus-3.8</id>
<properties>
<quarkus.version>3.8.3</quarkus.version>
</properties>
</profile>

<profile>
<id>native</id>
<properties>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<!-- runtime/test dependencies -->
<quarkus.version>3.8.3</quarkus.version>
<quarkus.version>3.9.1</quarkus.version>
<zalando-problem.version>0.27.1</zalando-problem.version>
<assertj.version>3.25.3</assertj.version>
<jmh.version>1.37</jmh.version>
Expand Down
4 changes: 2 additions & 2 deletions runtime/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy-reactive-jackson</artifactId>
<artifactId>quarkus-rest-jackson</artifactId>
<optional>true</optional>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy-reactive-jsonb</artifactId>
<artifactId>quarkus-rest-jsonb</artifactId>
<optional>true</optional>
</dependency>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@
import jakarta.ws.rs.NotFoundException;
import jakarta.ws.rs.Priorities;

/**
* Mapper overriding default Quarkus exception mapper to make all error responses compliant with RFC7807.
*
* @see io.quarkus.resteasy.runtime.NotFoundExceptionMapper
*/
@Priority(Priorities.USER)
public final class NotFoundExceptionMapper extends ExceptionMapperBase<NotFoundException> {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.tietoevry.quarkus.resteasy.problem.jaxrs;

import static com.tietoevry.quarkus.resteasy.problem.ExceptionMapperAssert.assertThat;
import static org.assertj.core.api.Assertions.assertThat;

import jakarta.ws.rs.NotFoundException;
Expand All @@ -11,12 +10,6 @@ class NotFoundExceptionMapperTest {

NotFoundExceptionMapper mapper = new NotFoundExceptionMapper();

@Test
void shouldHaveHigherPriorityThanBuiltInMapper() {
assertThat(mapper.getClass())
.hasPrecedenceOver(io.quarkus.resteasy.runtime.NotFoundExceptionMapper.class);
}

@Test
void shouldProduceHttp404() {
NotFoundException exception = new NotFoundException();
Expand Down