use .readSecretJson in VaultCredentialsProvider #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vsevel You're in a better position to determine if this is the best fix for this. |
vsevel
reviewed
Oct 8, 2024
| @@ -56,7 +56,7 @@ public Map<String, String> getCredentials(String credentialsProviderName) { | |||
| } | |||
|
|
|||
| if (config.kvPath().isPresent()) { | |||
| String password = vaultKVSecretEngine.readSecret(config.kvPath().get()).get(config.kvKey()); | |||
| String password = String.valueOf(vaultKVSecretEngine.readSecretJson(config.kvPath().get()).get(config.kvKey())); | |||
There was a problem hiding this comment.
this is fine. I would just add a check for nullity (assuming a null password does not make sense; and was not supported anyway).
var val = vaultKVSecretEngine.readSecretJson(config.kvPath().get()).get(config.kvKey());
if(val == null) {
throw new VaultException("unable to retrieve credential "+config.kvKey()+" from path "+config.kvPath().get());
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327
I have tested this in my own fork of the repo, and confirmed it to be working.
Under
.getCredentials(), the current code uses.readSecret()which will fail if the secret containing the password contains a null value, e.g.:This PR uses
.readSecretJson()instead, which does not assume the secret's values are always String, and converts it to String usingString.valueOf().One caveat is that it will no longer (implicitly) guarantee the password to never be null. I am open to suggestions on this point.