Quarkus 3.0.0.Alpha1

[vsevel]

move to quarkus 3.0.0.Alpha1

[vsevel]

hello @gastaldi
I have change everything to go along 3.0.0.Alpha1.
IT fail on testcontainers because of:

Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 46.67 s <<< FAILURE! - in io.quarkus.vault.VaultClientTokenWrapITCase
Error:  io.quarkus.vault.VaultClientTokenWrapITCase  Time elapsed: 46.669 s  <<< ERROR!
java.util.concurrent.CompletionException: java.lang.NoClassDefFoundError: javax/servlet/DispatcherType
Caused by: java.lang.NoClassDefFoundError: javax/servlet/DispatcherType
Caused by: java.lang.ClassNotFoundException: javax.servlet.DispatcherType

I see that @gsmet added javax.xml.bind:jaxb-api and javax.annotation:javax.annotation-api exclusions back in 2019 on the org.tescontainers:postgresql back in 2019.
do you know if something needs to be done for javax.servlet as well?
cc @maxandersen

[gastaldi]

@vsevel I have no idea TBH, someone would need to debug and find where this class is used

[vsevel]

needed to add:

        <dependency>
            <groupId>javax.servlet</groupId>
            <artifactId>javax.servlet-api</artifactId>
            <version>${javax.servlet-api.version}</version>
        </dependency>

since it is on the test-framework module, it does not leak into runtime or deployment.
not sure why testcontainers needs it.

[vsevel]

the issue is actually with wiremock:

java.util.concurrent.CompletionException: java.lang.NoClassDefFoundError: javax/servlet/DispatcherType
        at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315)
        at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320)
        at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1807)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.NoClassDefFoundError: javax/servlet/DispatcherType
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:375)
        at com.github.tomakehurst.wiremock.jetty9.JettyHttpServerFactory.getServerConstructor(JettyHttpServerFactory.java:37)
        at com.github.tomakehurst.wiremock.jetty9.JettyHttpServerFactory.<clinit>(JettyHttpServerFactory.java:30)
        at com.github.tomakehurst.wiremock.core.WireMockConfiguration.<init>(WireMockConfiguration.java:93)
        at com.github.tomakehurst.wiremock.core.WireMockConfiguration.wireMockConfig(WireMockConfiguration.java:130)
        at io.quarkus.vault.WiremockVault.start(WiremockVault.java:23)
        at io.quarkus.test.common.TestResourceManager$TestResourceEntryRunnable.run(TestResourceManager.java:471)
        at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804)
        ... 3 more
Caused by: java.lang.ClassNotFoundException: javax.servlet.DispatcherType
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
        ... 12 more

[gsmet]

@vsevel I solved it in the Quarkus build by using wiremock-standalone: https://search.maven.org/artifact/com.github.tomakehurst/wiremock-standalone/2.27.2/jar

[vsevel]

thanks for the tip @gsmet - this worked well. and I was even able to remove the old exclusions that we had on wiremock.
I checked the javax dependencies again, and all I see is:

[INFO] +- io.quarkus:quarkus-junit5:jar:3.0.0.Alpha1:test
[INFO] |  +- io.quarkus:quarkus-test-common:jar:3.0.0.Alpha1:test
[INFO] |  |  +- io.quarkus:quarkus-bootstrap-maven-resolver:jar:3.0.0.Alpha1:test
[INFO] |  |  |  +- org.apache.maven:maven-embedder:jar:3.8.6:test
[INFO] |  |  |  |  +- javax.inject:javax.inject:jar:1:test
[INFO] |  |  |  |  +- javax.annotation:javax.annotation-api:jar:1.3.2:test

I am assuming this is known, and we can't do anything about it.

@kdubb would you be able to do the review?

[vsevel]

hi @sberyozkin can you help me with the review? or would you suggest somebody else?

[gsmet]

Looks nearly good, except for the import formatting that we tried to improve in quarkiverse-parent 11. See my comment inline.

[gsmet]

Yes that's exactly what you should do.

[gsmet]

@ia3andy I wonder if we should add a recipe adjusting these dependencies. Most people won't use them directly but that might be worth it anyway. The ones that got adjusted this way are JAX-RS and JAXB.

[ia3andy]

@gsmet isn't quarkus providing that dependency?

[vsevel]

@gsmet thanks for the review. I rebased and re-sorted the imports. everything is ok now.
@gastaldi I applied your changes in .github/workflows/quarkus-snapshot.yaml regarding uses: actions/...@v3.
if nothing else, I will squash and merge in main, and create an Alpha release at some point.
@maxandersen is there a timeline for producing Alpha releases for all extensions?