Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo/inaccuracy in the EU-21-Rossi_Bellom-2021_A_Titan_M_Odyssey.pdf paper #8

Closed
NewDwarf opened this issue Nov 24, 2021 · 1 comment

Comments

@NewDwarf
Copy link

The EU-21-Rossi_Bellom-2021_A_Titan_M_Odyssey.pdf paper has possible typo or inaccuracy in 'Key Blob structure' description, p. 49.
The paper claims that last 32 bytes of the key blob starting from 0x5e0 offset is the SHA256 digest. But it is not so. It is HMAC-SHA256.
I think it doesn't make sense to use just SHA256 there as just a hash doesn't guarantee the authenticity. But HMAC does.

@dmell
Copy link
Contributor

dmell commented Nov 24, 2021

Hello,

Thank you for your comment! The last 32 bytes are indeed an HMAC digest. I think this was a simple typo since the same slide shows the portion of key blob being authenticated. I will fix that right away.

@dmell dmell closed this as completed in 4d7033f Nov 24, 2021
dmell added a commit that referenced this issue Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants