[Master] Updated module 004 module to reproduce data loss issues #125

Sgitario · 2021-03-09T12:39:25Z

Added coverage for issues:

Data loss after update to Quarkus 1.10.5 quarkusio/quarkus#14201
Hibernate data loss bug: Hibernate can null out a row in some circumstances quarkusio/quarkus#14881

Note that this solution is based on the reproducer provided in one of the above issues: https://github.com/yntelectual/quarkus-bug-14201

I verified that the new test does not work if we run it with 1.11.1.Final (as an example):

mvn clean install -Dquarkus-plugin.version=1.11.1.Final -Dquarkus.platform.version=1.11.1.Final

As expected, It fails with:

Caused by: org.postgresql.util.PSQLException: ERROR: null value in column "email" of relation "account" violates not-null constraint
  Detail: Failing row contains (1, null, null).
	at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2553)
	at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2285)
	at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:323)
	at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:473)
	at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:393)
	at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:164)
	at org.postgresql.jdbc.PgPreparedStatement.executeUpdate(PgPreparedStatement.java:130)
	at io.agroal.pool.wrapper.PreparedStatementWrapper.executeUpdate(PreparedStatementWrapper.java:86)
	at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.executeUpdate(ResultSetReturnImpl.java:197)

It works fine when running with 1.11.5.Final or 999-SNAPSHOT. Verified also in Native.

This PR must be backported to 1.11 branch too.

kshpak · 2021-03-09T16:18:11Z

Just at the first glance, can it be integrated inside 004-quarkus-HHH-and-HV module?

Sgitario · 2021-03-10T06:22:35Z

Just at the first glance, can it be integrated inside 004-quarkus-HHH-and-HV module?

Very good suggestion! My concern was that this issue could not be reproduced using a H2 instance, but it is. I've removed the module 021 and added the test into the 004 module as you suggested.
Thanks so much!

Sgitario · 2021-03-10T06:59:57Z

The failure is related to #126

kshpak · 2021-03-11T12:17:37Z

004-quarkus-HHH-and-HV/src/main/resources/import.sql

+truncate table item cascade ;
+truncate table customer cascade ;
+truncate table account_in_role cascade ;
+truncate table account cascade ;
+truncate table role cascade ;
+start TRANSACTION ;


This is redundant IMO, because you have set quarkus.hibernate-orm.database.generation=drop-and-create
Plus it throwing errors anyway.

Removed, thanks!

rsvoboda

Please get rid of JdbcSQLException: Syntax error in SQL statement warnings

2021-03-11 14:51:57,157 WARN  [org.hib.too.sch.int.ExceptionHandlerLoggedImpl] (main) GenerationTarget encountered exception accepting command : Error executing DDL "truncate table item cascade" via JDBC Statement: org.hibernate.tool.schema.spi.CommandAcceptanceException: Error executing DDL "truncate table item cascade" via JDBC Statement
	at org.hibernate.tool.schema.internal.exec.GenerationTargetToDatabase.accept(GenerationTargetToDatabase.java:67)
	at org.hibernate.tool.schema.internal.SchemaCreatorImpl.applySqlString(SchemaCreatorImpl.java:439)
	at org.hibernate.tool.schema.internal.SchemaCreatorImpl.applyImportSources(SchemaCreatorImpl.java:492)
	at org.hibernate.tool.schema.internal.SchemaCreatorImpl.performCreation(SchemaCreatorImpl.java:180)
	at org.hibernate.tool.schema.internal.SchemaCreatorImpl.doCreation(SchemaCreatorImpl.java:135)
	at org.hibernate.tool.schema.internal.SchemaCreatorImpl.doCreation(SchemaCreatorImpl.java:121)
	at org.hibernate.tool.schema.spi.SchemaManagementToolCoordinator.performDatabaseAction(SchemaManagementToolCoordinator.java:156)
	at org.hibernate.tool.schema.spi.SchemaManagementToolCoordinator.process(SchemaManagementToolCoordinator.java:73)
	at org.hibernate.internal.SessionFactoryImpl.<init>(SessionFactoryImpl.java:318)
	at io.quarkus.hibernate.orm.runtime.boot.FastBootEntityManagerFactoryBuilder.build(FastBootEntityManagerFactoryBuilder.java:73)
	at io.quarkus.hibernate.orm.runtime.FastBootHibernatePersistenceProvider.createEntityManagerFactory(FastBootHibernatePersistenceProvider.java:67)
	at javax.persistence.Persistence.createEntityManagerFactory(Persistence.java:80)
	at javax.persistence.Persistence.createEntityManagerFactory(Persistence.java:55)
	at io.quarkus.hibernate.orm.runtime.JPAConfig$LazyPersistenceUnit.get(JPAConfig.java:117)
	at io.quarkus.hibernate.orm.runtime.JPAConfig.startAll(JPAConfig.java:41)
	at io.quarkus.hibernate.orm.runtime.HibernateOrmRecorder.startAllPersistenceUnits(HibernateOrmRecorder.java:88)
	at io.quarkus.deployment.steps.HibernateOrmProcessor$startPersistenceUnits951856026.deploy_0(HibernateOrmProcessor$startPersistenceUnits951856026.zig:74)
	at io.quarkus.deployment.steps.HibernateOrmProcessor$startPersistenceUnits951856026.deploy(HibernateOrmProcessor$startPersistenceUnits951856026.zig:40)
	at io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:641)
	at io.quarkus.runtime.Application.start(Application.java:90)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.runner.bootstrap.StartupActionImpl.run(StartupActionImpl.java:212)
	at io.quarkus.test.junit.QuarkusTestExtension.doJavaStart(QuarkusTestExtension.java:331)
	at io.quarkus.test.junit.QuarkusTestExtension.ensureStarted(QuarkusTestExtension.java:638)
	at io.quarkus.test.junit.QuarkusTestExtension.beforeAll(QuarkusTestExtension.java:684)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$8(ClassBasedTestDescriptor.java:368)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeBeforeAllCallbacks(ClassBasedTestDescriptor.java:368)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:192)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:78)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:136)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:129)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:127)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:126)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:84)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:143)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:129)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:127)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:126)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:84)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:220)
	at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$6(DefaultLauncher.java:188)
	at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:202)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:181)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:128)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:142)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:117)
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
Caused by: org.h2.jdbc.JdbcSQLException: Syntax error in SQL statement "TRUNCATE TABLE ITEM CASCADE[*] "; SQL statement:
truncate table item cascade [42000-197]
...
Caused by: org.h2.jdbc.JdbcSQLException: Syntax error in SQL statement "START[*] TRANSACTION "; expected "SELECT, SET, SAVEPOINT, SCRIPT, SHUTDOWN, SHOW, {"; SQL statement:

rsvoboda · 2021-03-11T14:09:49Z

import.sql should imho look like this to get rid of nasty stacktraces

BEGIN TRANSACTION;
insert into account (id, email) values (1, 'foo@bar.com');
insert into role (id, name) values  (1, 'admin');
insert into account_in_role (accountid, roleid) values (1, 1);
insert into customer (id, version, account_id) values (1,  1, 1);
insert into item (id, note, customerid) values (1, 'Item 1', 1);
COMMIT;

004-quarkus-HHH-and-HV/src/main/java/io/quarkus/qe/hibernate/items/ItemsResource.java

Sgitario · 2021-03-11T14:44:08Z

I think I've addressed all your comments. Would you mind reviewing again? Thanks a lot for your input!

004-quarkus-HHH-and-HV/src/main/resources/import.sql

004-quarkus-HHH-and-HV/README.md

004-quarkus-HHH-and-HV/src/main/resources/import.sql

rsvoboda · 2021-03-12T11:00:05Z

Native run is stuck

Error: Exception in thread "ForkJoinPool-3-worker-1" java.lang.OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects
Error: Exception in thread "ForkJoinPool-3-worker-1" java.lang.OutOfMemoryError: GC overhead limit exceeded

Sgitario requested review from mjurc and kshpak March 9, 2021 12:39

Sgitario force-pushed the module_for_749 branch from 49c06a0 to a1c7c38 Compare March 10, 2021 06:21

Sgitario changed the title ~~Added 021-quarkus-hibernate module for QUARKUS-749~~ Updated module 004 module to reproduce data loss issues Mar 10, 2021

Sgitario force-pushed the module_for_749 branch from a1c7c38 to fb99eb9 Compare March 10, 2021 10:30

kshpak reviewed Mar 11, 2021

View reviewed changes

rsvoboda requested changes Mar 11, 2021

View reviewed changes

kshpak reviewed Mar 11, 2021

View reviewed changes

004-quarkus-HHH-and-HV/src/main/java/io/quarkus/qe/hibernate/items/ItemsResource.java Outdated Show resolved Hide resolved

Sgitario force-pushed the module_for_749 branch from fb99eb9 to c35a3c5 Compare March 11, 2021 14:42

Sgitario requested review from rsvoboda and kshpak March 11, 2021 14:43

rsvoboda reviewed Mar 11, 2021

View reviewed changes

004-quarkus-HHH-and-HV/src/main/resources/import.sql Show resolved Hide resolved

kshpak reviewed Mar 11, 2021

View reviewed changes

004-quarkus-HHH-and-HV/README.md Outdated Show resolved Hide resolved

rsvoboda reviewed Mar 11, 2021

View reviewed changes

004-quarkus-HHH-and-HV/src/main/resources/import.sql Outdated Show resolved Hide resolved

Sgitario force-pushed the module_for_749 branch from c35a3c5 to 612bb45 Compare March 12, 2021 05:32

Sgitario requested review from kshpak and rsvoboda March 12, 2021 05:33

rsvoboda approved these changes Mar 12, 2021

View reviewed changes

Updated module 004 module to reproduce data loss issues

b178909

Sgitario force-pushed the module_for_749 branch from 612bb45 to b178909 Compare March 12, 2021 08:40

Sgitario changed the title ~~Updated module 004 module to reproduce data loss issues~~ [Master] Updated module 004 module to reproduce data loss issues Mar 12, 2021

mjurc approved these changes Mar 12, 2021

View reviewed changes

kshpak approved these changes Mar 12, 2021

View reviewed changes

rsvoboda merged commit e83bcc8 into quarkus-qe:master Mar 12, 2021

Sgitario mentioned this pull request Mar 12, 2021

[1.11] Updated module 004 module to reproduce data loss issues #135

Merged

Sgitario deleted the module_for_749 branch March 12, 2021 12:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Master] Updated module 004 module to reproduce data loss issues #125

[Master] Updated module 004 module to reproduce data loss issues #125

Sgitario commented Mar 9, 2021 •

edited

Loading

kshpak commented Mar 9, 2021

Sgitario commented Mar 10, 2021

Sgitario commented Mar 10, 2021

kshpak Mar 11, 2021

Sgitario Mar 11, 2021

rsvoboda left a comment

rsvoboda commented Mar 11, 2021

Sgitario commented Mar 11, 2021

rsvoboda commented Mar 12, 2021

[Master] Updated module 004 module to reproduce data loss issues #125

[Master] Updated module 004 module to reproduce data loss issues #125

Conversation

Sgitario commented Mar 9, 2021 • edited Loading

kshpak commented Mar 9, 2021

Sgitario commented Mar 10, 2021

Sgitario commented Mar 10, 2021

kshpak Mar 11, 2021

Choose a reason for hiding this comment

Sgitario Mar 11, 2021

Choose a reason for hiding this comment

rsvoboda left a comment

Choose a reason for hiding this comment

rsvoboda commented Mar 11, 2021

Sgitario commented Mar 11, 2021

rsvoboda commented Mar 12, 2021

Sgitario commented Mar 9, 2021 •

edited

Loading