Merge pull request #385 from rsvoboda/fixes.v2

Add more clarity for RSS and timeToFirstOKRequest
quarkus-qe · Aug 13, 2024 · 643dadc · 643dadc
2 parents 1d63522 + 5ce3400
commit 643dadc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/testsuite/src/it/java/io/quarkus/ts/startstop/StartStopTest.java b/testsuite/src/it/java/io/quarkus/ts/startstop/StartStopTest.java
@@ -195,8 +195,8 @@ public void testRuntime(TestInfo testInfo, Apps app, MvnCmds mvnCmds, Supplier<U
  LOGGER.info("Calculating the stats");
  long rssKbAvgWithoutMinMax = getAvgWithoutMinMax(rssKbList);
  long timeToFirstOKRequestAvgWithoutMinMax = getAvgWithoutMinMax(timeToFirstOKRequestList);
- LOGGER.info("AVG timeToFirstOKRequest without min and max values: " + timeToFirstOKRequestAvgWithoutMinMax);
- LOGGER.info("AVG rssKb without min and max values: " + rssKbAvgWithoutMinMax);
+ LOGGER.info("AVG timeToFirstOKRequest (ms) without min and max values: " + timeToFirstOKRequestAvgWithoutMinMax);
+ LOGGER.info("AVG RSS (kB) without min and max values: " + rssKbAvgWithoutMinMax);
  checkThreshold(app, mvnCmds, rssKbAvgWithoutMinMax, timeToFirstOKRequestAvgWithoutMinMax, SKIP);
  } finally {
  // Make sure processes are down even if there was an exception / failure

diff --git a/testsuite/src/it/java/io/quarkus/ts/startstop/utils/Logs.java b/testsuite/src/it/java/io/quarkus/ts/startstop/utils/Logs.java
@@ -180,7 +180,7 @@ public static void checkThreshold(Apps app, MvnCmds cmd, long rssKb, long timeTo
  if (rssKb != SKIP) {
  long rssThresholdKb = app.thresholdProperties.get(propPrefix + ".RSS.threshold.kB");
  assertTrue(rssKb <= rssThresholdKb,
- "Application " + app + " in " + cmd + " consumed " + rssKb + " kB, which is over " +
+ "Application " + app + " in " + cmd + " consumed " + rssKb + " kB of RSS memory, which is over " +
  rssThresholdKb + " kB threshold.");
  }
  if (timeToReloadedOKRequest != SKIP) {