Fix calling of ServiceListeners on error as when BaseService.isRunningOrFailed
fails error is not caught
#936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I am debugging failing
OperatorOpenShiftInfinispanObjectsIT
and I can see resources are not cleared. One way could be to useio.quarkus.test.bootstrap.ServiceListener
, but it doesn't work as expected, because following exceptionis not caught. I expect
io.quarkus.test.bootstrap.ServiceListener#onServiceError
to always be called, otherwise what is the point.Please check the relevant options
run tests
phrase in comment)Checklist: