Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sql-db compatibility module, name prefix sync #1174

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

rsvoboda
Copy link
Member

Refactor sql-db compatibility module, name prefix sync

  • use io.quarkus.ts.sqldb.compatibility package
  • drop dev mode and OpenShift test for compatibility module
    • functionality ensured in "bare-metal" scenarios
  • native mode ensured on MariaDB, MSSQL, PostgreSQL
    • MySQL, DB2 and Oracle skipped in native mode in compatibility module
    • More details: MySQL and MariaDB are close to each other, DB2 is not fully supported, Oracle is supported in JVM

This change relates to #1171
Reducing the time from 01:17 h to ~35 minutes

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda rsvoboda requested a review from michalvavrik April 14, 2023 07:14
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@michalvavrik michalvavrik merged commit ecf4c96 into quarkus-qe:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants