Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for issue 36402 #1510

Closed
wants to merge 1 commit into from
Closed

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Nov 8, 2023

for branch 3.2

Summary

Copy of #1508 for branch 3.2

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from michalvavrik November 8, 2023 14:40
@rsvoboda
Copy link
Member

rsvoboda commented Nov 8, 2023

The flow is to add backport 3.2 label on the original PR, issues should be backported in a bulk
CC @michalvavrik

@mocenas
Copy link
Contributor Author

mocenas commented Nov 8, 2023

The flow is to add backport 3.2 label on the original PR, issues should be backported in a bulk CC @michalvavrik

OK, I've added label to original PR. should I make this a draft and backport it when all issues are covered? @rsvoboda

@rsvoboda
Copy link
Member

rsvoboda commented Nov 8, 2023

Please close this one, the idea is to have control over the things that go into 3.2 branch and have the backports reviewed by the gatekeeper. Bulks also save some resources on CI side and should allow better scaling of the work.

@mocenas mocenas closed this Nov 8, 2023
@michalvavrik
Copy link
Member

Please close this one, the idea is to have control over the things that go into 3.2 branch and have the backports reviewed by the gatekeeper. Bulks also save some resources on CI side and should allow better scaling of the work.

+1; You Shall Not Pass @mocenas :-)

OK, I've added label to original PR. should I make this a draft and backport it when all issues are covered? @rsvoboda

It's fine if you do bulk backport PR when 3.2 test coverage is finished and request my review, thank you. We will need to run OCP tests as I forgot to run one for your PR. If for any reason you want me to do backports, please ping me, it's my duty anyway. One way or another, please get me involved again.

@michalvavrik
Copy link
Member

Truth be told I also didn't mention until now that original PR has 3 commits, shame on me. Good that you squashed it for backports.

@mocenas mocenas deleted the sse_3.2 branch January 9, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants