Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for check SSE reactive empty response data #1517

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Nov 13, 2023

Summary

Adding the test based on scenario from quarkusio/quarkus#35966. When developing it there are some issues so for now it's disabled (quarkusio/quarkus#37033 and quarkusio/quarkus#36986).

Test should run on ocp as well but as it it disable I don't see much point to run it now.

Maybe it would be nice to add this scenario (with empty request) to http-advanced (non-reactive)? There is recent test for SSE but with this there will need be some small adjustment to it. WDYT?

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member

Maybe it would be nice to add this scenario (with empty request) to http-advanced (non-reactive)? There is recent test for SSE but with this there will need be some small adjustment to it. WDYT?

My impression is that RESTEasy Classic and SSE don't go together too well: #1511 (comment)

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You checked off follow the best practices https://cbea.ms/git-commit/ but in https://cbea.ms/git-commit/ I can see rule number 4. Do not end the subject line with a period Can you please try to provide more descriptive PR title? I know it's hard, I hardly ever do it right, but I think you can do better. Thanks

@michalvavrik
Copy link
Member

@jedla97 lgtm (+ please address note above on PR title), but let's wait to quarkusio/quarkus#37035 and enable native test before this go in

@michalvavrik michalvavrik self-requested a review November 14, 2023 11:28
@jedla97 jedla97 changed the title Add test for SSE reactive. Add test for check SSE reactive empty response data Nov 14, 2023
@jedla97
Copy link
Member Author

jedla97 commented Nov 14, 2023

@michalvavrik Title updated, Last push was just change commit typo. No problem waiting. Hope it will be quick

@michalvavrik
Copy link
Member

@jedla97 I'm starting to think upstream PR won't go in anytime soon. Please rebase so that we can get this in.

@jedla97
Copy link
Member Author

jedla97 commented Nov 15, 2023

run tests

@jedla97
Copy link
Member Author

jedla97 commented Nov 15, 2023

@michalvavrik rebased + I run test as the BaseHttpAdvancedReactiveIT tests are included in openshift

@michalvavrik michalvavrik merged commit 61e216e into quarkus-qe:main Nov 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants