-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non json resteasy reactive #1599
Non json resteasy reactive #1599
Conversation
73cda92
to
b4bf296
Compare
.../http-advanced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/CityResource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to add the image payload test too btw?
.../http-advanced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/CityResource.java
Outdated
Show resolved
Hide resolved
...p-advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/NonJsonPayLoadIT.java
Outdated
Show resolved
Hide resolved
...p-advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/NonJsonPayLoadIT.java
Outdated
Show resolved
Hide resolved
...d-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/CityListWrapperSerializer.java
Show resolved
Hide resolved
.../http-advanced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/CityResource.java
Outdated
Show resolved
Hide resolved
...p-advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/NonJsonPayLoadIT.java
Outdated
Show resolved
Hide resolved
...p-advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/NonJsonPayLoadIT.java
Show resolved
Hide resolved
Yes, I will push it today if there are no setbacks. |
4f52889
to
57612c2
Compare
...p-advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/NonJsonPayLoadIT.java
Outdated
Show resolved
Hide resolved
...p-advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/NonJsonPayLoadIT.java
Outdated
Show resolved
Hide resolved
.../http-advanced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/CityResource.java
Outdated
Show resolved
Hide resolved
50d4287
to
513e030
Compare
.../http-advanced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/CityResource.java
Outdated
Show resolved
Hide resolved
875f05e
to
1758449
Compare
35f33d7
to
54e08c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you can answer well my comment, thanks
.../http-advanced-reactive/src/main/java/io/quarkus/ts/http/advanced/reactive/YamlProvider.java
Show resolved
Hide resolved
1b5352e
to
b41dc74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcarranzan thanks for the coverage, code LGTM, but please squash the commits and update the commit message to be more helpful
Body: Introduce tests for Quarkus REST endpoints handling XML, YAML, and image payloads.Includes XML response tests, posting XML/YAML payloads, and image retrieval/multipart upload validations. d non-json payload tests remove unused imports add @produce to the Provider fix to a valid format
2ad8583
to
e694108
Compare
Summary
Create test cases that evolve non-JSON payload in REST endpoints as described in the Jira task:
https://issues.redhat.com/browse/QQE-343
Scenario: Verify that the endpoint properly consumes and produces XML payloads.
Please select the relevant options.
run tests
phrase in comment)Checklist: