Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non json resteasy reactive #1599

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

jcarranzan
Copy link
Contributor

@jcarranzan jcarranzan commented Jan 8, 2024

Summary

Create test cases that evolve non-JSON payload in REST endpoints as described in the Jira task:
https://issues.redhat.com/browse/QQE-343

  1. XML scenario:
    Scenario: Verify that the endpoint properly consumes and produces XML payloads.
  • Check the endpoint that returns a valid XML.
  • Send a request with an XML payload to the endpoint.
  • Validate the response.
  • Ensure the response's content matches the expected from the XML structure.
  1. YAML scenario
  • Check the endpoint that returns a Yaml from a Yaml file.
  • Send a request with a Yaml payload from a file to an endpoint.
  • Validate the response
  • Ensure the response's content matches the expected from the YAML content.
  1. Image scenario
  • Verify the endpoint that returns an image by making a GET request.
  • Send Image in Multipart Form
  • Check the endpoint that handles image upload as part of a multipart form by making a POST request.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan marked this pull request as draft January 8, 2024 08:33
@jcarranzan jcarranzan force-pushed the non-json-resteasy-reactive branch 5 times, most recently from 73cda92 to b4bf296 Compare January 17, 2024 07:50
@jcarranzan jcarranzan marked this pull request as ready for review January 17, 2024 07:50
@jcarranzan jcarranzan requested a review from mjurc January 17, 2024 07:57
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to add the image payload test too btw?

@jcarranzan
Copy link
Contributor Author

Are you planning to add the image payload test too btw?

Yes, I will push it today if there are no setbacks.

@jcarranzan jcarranzan force-pushed the non-json-resteasy-reactive branch 7 times, most recently from 4f52889 to 57612c2 Compare January 19, 2024 18:10
@jcarranzan jcarranzan force-pushed the non-json-resteasy-reactive branch from 50d4287 to 513e030 Compare January 21, 2024 08:31
@jcarranzan jcarranzan force-pushed the non-json-resteasy-reactive branch from 875f05e to 1758449 Compare January 21, 2024 18:15
@michalvavrik michalvavrik requested a review from mjurc January 21, 2024 19:18
@jcarranzan jcarranzan force-pushed the non-json-resteasy-reactive branch 3 times, most recently from 35f33d7 to 54e08c3 Compare January 26, 2024 14:31
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you can answer well my comment, thanks

@jcarranzan jcarranzan force-pushed the non-json-resteasy-reactive branch from 1b5352e to b41dc74 Compare January 26, 2024 16:14
mjurc
mjurc approved these changes Jan 26, 2024
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcarranzan thanks for the coverage, code LGTM, but please squash the commits and update the commit message to be more helpful

Body:
Introduce tests for Quarkus REST endpoints handling XML, YAML, and image payloads.Includes XML response tests, posting XML/YAML payloads, and image retrieval/multipart upload validations.

d non-json payload tests
remove unused imports
add @produce to the Provider

fix to a valid format
@jcarranzan jcarranzan force-pushed the non-json-resteasy-reactive branch from 2ad8583 to e694108 Compare January 26, 2024 21:46
@michalvavrik michalvavrik merged commit 208042f into quarkus-qe:main Jan 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants