Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Snappy tests in native, disable invalid DEV mode test and enable OpenShift native snappy test #1851

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jun 24, 2024

Summary

  • daily build is failing as SnappyCompressionIT is failing in native, Kafka reference https://quarkus.io/version/main/guides/kafka#using-snappy-for-message-compression says use quarkus.kafka.snappy.enabled=true
  • OpenShiftKafkaSnappyIT was disabled in OpenShift in native mode, enabling it
  • KafkaConsumer was not closed
  • DevModeKafkaSnappyIT started: dev mode app, redpanda, prod mode app and kafka container (4 things), then tested:
    • exactly same thing as was already tested by SnappyCompressionIT also in prod mode, not in the DEV mode!
    • in the DEV mode, it tested that Redpanda was started, nothing else
    • the DevModeKafkaSnappyIT is wrong name for test that does one thing related to DEV mode: test kafkaContainerShouldBeStarted
    • there is no test plan matched or JIRA ticket matched with Add snappy compression test coverage #1799 so I cannot tell what are requirements on the DEV mode test
    • IMHO this needs to be refactored, therefore disabling it with TODO

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik requested a review from jcarranzan June 24, 2024 21:58
@jcarranzan jcarranzan merged commit 6df539e into quarkus-qe:main Jun 25, 2024
10 checks passed
@michalvavrik michalvavrik deleted the feature/fix-snappy-in-native branch June 25, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants