Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] [QUARKUS-4541] Fix test to verify that failed unis are not cached #1874

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[3.8] [QUARKUS-4541] Fix test to verify that failed unis are not cached #1874

merged 1 commit into from
Jul 9, 2024

Conversation

jcarranzan
Copy link
Contributor

@jcarranzan jcarranzan commented Jul 8, 2024 •
edited
Loading

Summary

Fix logic test to verify that failed unis are not cached according this fix:

quarkusio/quarkus#39762
It's backport of #1873 (review)

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan requested a review from jedla97 July 8, 2024 08:12
@jcarranzan jcarranzan force-pushed the 3.8.5.CR2 branch 3 times, most recently from 804fb5b to 0044581 Compare July 8, 2024 09:26
@jcarranzan jcarranzan marked this pull request as ready for review July 8, 2024 10:53
jedla97
jedla97 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the 3.8 branch. I don't see anything which differ from #1873

@jcarranzan can you also update description that this need to ocp run and add it's backport of #1873

@jedla97
Copy link
Member

jedla97 commented Jul 9, 2024

run tests

@jedla97 jedla97 merged commit 9fd8924 into quarkus-qe:3.8 Jul 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedla97 jedla97 jedla97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcarranzan @jedla97