-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage for Infinispan cache extension #1914
Conversation
run tests |
are there any test plans? |
No test plan, if you require it I can create. The tests except caffeine cases must cover complex Java types marshalling and cache expiration. I went through docs and upstream PR |
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what about tracing and metrics? Does this extensions generate any?
|
||
private static final String CACHE_NAME = "service-cache"; | ||
|
||
private static int counter = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems, that this value may potentially be changed from the several threads. Please, change this variable to Atomic or another race-protected alternative
TP needs to be done for new features landing in product support |
e1fa736
to
df27287
Compare
run tests |
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But please double-check, that failures in CI are unrelated
Failures are unrelated for this PR, I work on them in the part of other task |
@gtroitsk could you link the task for a reference? |
QQE-866 |
Summary
Test coverage for QQE-832
TP: https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QQE-832.md
New tests:
ExpensiveResponse
in cache service.testCacheLifespan
andtestCacheMaxIdle
.Please select the relevant options.
run tests
phrase in comment)Checklist: