Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for Infinispan cache extension #1914

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Aug 2, 2024

Summary

Test coverage for QQE-832
TP: https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QQE-832.md

New tests:

  • Use custom POJOs as cache value, verify marshalling in Quarkus Infinispan. See ExpensiveResponse in cache service.
  • Test Cache expiration properties. testCacheLifespan and testCacheMaxIdle.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk marked this pull request as ready for review August 2, 2024 14:09
@gtroitsk
Copy link
Member Author

gtroitsk commented Aug 2, 2024

run tests

@gtroitsk gtroitsk requested a review from fedinskiy August 2, 2024 14:14
@fedinskiy
Copy link
Contributor

are there any test plans?

@gtroitsk
Copy link
Member Author

gtroitsk commented Aug 2, 2024

are there any test plans?

No test plan, if you require it I can create. The tests except caffeine cases must cover complex Java types marshalling and cache expiration. I went through docs and upstream PR

@github-actions github-actions bot added the triage/flaky-test Signal that flaky tests were detected during CI run label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what about tracing and metrics? Does this extensions generate any?


private static final String CACHE_NAME = "service-cache";

private static int counter = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, that this value may potentially be changed from the several threads. Please, change this variable to Atomic or another race-protected alternative

@rsvoboda
Copy link
Member

rsvoboda commented Aug 6, 2024

TP needs to be done for new features landing in product support

@gtroitsk gtroitsk force-pushed the infinispan-cache-coverage branch from e1fa736 to df27287 Compare August 7, 2024 09:23
@gtroitsk gtroitsk requested a review from fedinskiy August 7, 2024 09:26
@gtroitsk
Copy link
Member Author

gtroitsk commented Aug 7, 2024

run tests

Copy link

github-actions bot commented Aug 7, 2024

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But please double-check, that failures in CI are unrelated

@gtroitsk
Copy link
Member Author

gtroitsk commented Aug 8, 2024

Failures are unrelated for this PR, I work on them in the part of other task

@fedinskiy
Copy link
Contributor

@gtroitsk could you link the task for a reference?

@gtroitsk
Copy link
Member Author

gtroitsk commented Aug 8, 2024

@gtroitsk could you link the task for a reference?

QQE-866

@fedinskiy fedinskiy merged commit 89988dd into quarkus-qe:main Aug 8, 2024
15 of 16 checks passed
@gtroitsk gtroitsk deleted the infinispan-cache-coverage branch August 8, 2024 09:43
@michalvavrik michalvavrik removed the triage/flaky-test Signal that flaky tests were detected during CI run label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants