Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using simple class name in MP Rest client configuration property keys as upstream removed support lately #2133

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Oct 24, 2024

Summary

Here quarkusio/quarkus#43345 behavior for MP Rest client configuration changed. Reasons are explained in here quarkusio/quarkus#44067 (comment). This behavior was never documented and now it is removed. Migration guide mentions this change https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.17#rest-client. I plan to use config key when quarkusio/quarkus#44073 is merged and 999-SNAPSHOT artifacts are deployed to Sonatype.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda
Copy link
Member

java.lang.IllegalStateException: Too many recursive interceptor actions in the logs

@michalvavrik
Copy link
Member Author

java.lang.IllegalStateException: Too many recursive interceptor actions in the logs

expected, tomorrow when quarkusio/quarkus#44073 is in the sonatype repo we will rerun CI

@rsvoboda
Copy link
Member

rsvoboda commented Oct 25, 2024

@michalvavrik something to look at:

Error:  io.quarkus.ts.http.advanced.reactive.HttpAdvancedReactiveIT.microprofileHttpClientRedirection
Error:    Run 1: HttpAdvancedReactiveIT>BaseHttpAdvancedReactiveIT.microprofileHttpClientRedirection:152 expected: <200> but was: <500>
Error:    Run 2: HttpAdvancedReactiveIT>BaseHttpAdvancedReactiveIT.microprofileHttpClientRedirection:152 expected: <200> but was: <500>
Error:    Run 3: HttpAdvancedReactiveIT>BaseHttpAdvancedReactiveIT.microprofileHttpClientRedirection:152 expected: <200> but was: <500>

@michalvavrik
Copy link
Member Author

michalvavrik commented Oct 25, 2024

@michalvavrik something to look at:

Error:  io.quarkus.ts.http.advanced.reactive.HttpAdvancedReactiveIT.microprofileHttpClientRedirection
Error:    Run 1: HttpAdvancedReactiveIT>BaseHttpAdvancedReactiveIT.microprofileHttpClientRedirection:152 expected: <200> but was: <500>
Error:    Run 2: HttpAdvancedReactiveIT>BaseHttpAdvancedReactiveIT.microprofileHttpClientRedirection:152 expected: <200> but was: <500>
Error:    Run 3: HttpAdvancedReactiveIT>BaseHttpAdvancedReactiveIT.microprofileHttpClientRedirection:152 expected: <200> but was: <500>

I tried it now against the latest 999-SNAPSHOT and it looks like the issue is not fixed. Roberto fixed raised exception but not the functionality. I'll open issue and change this PR because we need green CI.

@michalvavrik
Copy link
Member Author

hmm, reproducer I created does succeed, I'll need to check what is different here.

@michalvavrik
Copy link
Member Author

The difference is when it is simple class name, it fails :/

@michalvavrik
Copy link
Member Author

@rsvoboda rsvoboda merged commit 732cc8b into quarkus-qe:main Oct 25, 2024
7 checks passed
@michalvavrik michalvavrik deleted the feature/fix-mp-key branch October 25, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants