-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using simple class name in MP Rest client configuration property keys as upstream removed support lately #2133
Conversation
99e0fc8
to
cf87650
Compare
|
expected, tomorrow when quarkusio/quarkus#44073 is in the sonatype repo we will rerun CI |
@michalvavrik something to look at:
|
I tried it now against the latest 999-SNAPSHOT and it looks like the issue is not fixed. Roberto fixed raised exception but not the functionality. I'll open issue and change this PR because we need green CI. |
cf87650
to
0e80916
Compare
hmm, reproducer I created does succeed, I'll need to check what is different here. |
The difference is when it is simple class name, it fails :/ |
Summary
Here quarkusio/quarkus#43345 behavior for MP Rest client configuration changed. Reasons are explained in here quarkusio/quarkus#44067 (comment). This behavior was never documented and now it is removed. Migration guide mentions this change https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.17#rest-client. I plan to use config key when quarkusio/quarkus#44073 is merged and 999-SNAPSHOT artifacts are deployed to Sonatype.
Please select the relevant options.
run tests
phrase in comment)Checklist: