Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GrpcWebSocketListeners from http-advanced-* #2199

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Nov 15, 2024

Summary

Remove GrpcWebSocketListeners from http-advanced-*. They are currently unused. There were used before, but tests were changed in #1833 and those listeners are unused since that.

I know some tests are supposed to be reimplemented as part of #1832 but not sure if those listeners are supposed to be part of it. Should we preserve those @michalvavrik ?

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from michalvavrik November 15, 2024 12:20
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need listeners in the future, we can add them and write them according to what we need.

@mocenas
Copy link
Contributor Author

mocenas commented Nov 15, 2024

OK cc @gtroitsk

@michalvavrik michalvavrik merged commit c9a861c into quarkus-qe:main Nov 15, 2024
7 checks passed
@mocenas mocenas deleted the remove_grpc branch November 15, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants