Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage to verify correct application order of update receipes duiring Quarkus update #2219

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add test coverage to verify correct application order of update receipes duiring Quarkus update #2219

merged 1 commit into from
Nov 26, 2024

Conversation

jcarranzan
Copy link
Contributor

Summary

Add test coverage for coverage for 44183
This PR adds a test to verify that when updating a Quarkus application from version 3.5 to 3.15, the quarkus-rest-client-reactive-jackson extension is correctly transformed to quarkus-rest-client-jackson, and not incorrectly transformed to quarkus-resteasy-client-jackson.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan marked this pull request as ready for review November 26, 2024 13:32
@jcarranzan jcarranzan requested a review from mocenas November 26, 2024 13:32
@rsvoboda
Copy link
Member

I don't think Methods and classes used in PR scenarios are meaningful and Commits are well encapsulated and follow [the best practices](https://cbea.ms/git-commit/) are followed, please amend commit message and update PR title

mocenas
mocenas requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@mocenas mocenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the commit message is not good, change it to something more descriptive

quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/update/QuarkusCli35to315UpdateIT.java Outdated Show resolved Hide resolved
quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/update/QuarkusCli35to315UpdateIT.java Outdated Show resolved Hide resolved
@jcarranzan jcarranzan changed the title Add test to verify correct dependency transformation duiring Quarkus update Add test coverage to verify correct application order of update receipes duiring Quarkus update Nov 26, 2024
@jcarranzan
Add test to verify correct application order of update recipes
9fc1ded 
This test ensures that during the Quarkus update process, the update recipes are applied in the correct order to prevent incorrect dependency transformations.

It address the issue quarkusio/quarkus#44183
@jcarranzan jcarranzan requested a review from mocenas November 26, 2024 14:37
mocenas
mocenas approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@mocenas mocenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mocenas mocenas merged commit 9fff9cc into quarkus-qe:main Nov 26, 2024
7 checks passed
@jedla97 jedla97 mentioned this pull request Nov 27, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mocenas mocenas mocenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcarranzan @rsvoboda @mocenas @jedla97