Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NativeStorkServiceDiscoveryIT and StorkLoadBalancerIT #723

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jun 16, 2022

Summary

Tests fails as path called by Rest Client is not found. IMHO that's due to this PR. One way or another, adjusting resource/client paths fixes the issue. Daily run (Linux Native mode) are failing because of this issue. I read PR 26101 in a way that /pung/ is cut to /pung and so is the /pong/.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from pjgg June 16, 2022 12:32
@michalvavrik michalvavrik self-assigned this Jun 16, 2022
@michalvavrik michalvavrik force-pushed the feature/fix-service-discovery-tests branch 3 times, most recently from 9a47080 to 6b7fb40 Compare June 16, 2022 14:11
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tests fails as path called by Rest Client is not found. IMHO that's due to [this PR](quarkusio/quarkus#26101). One way or another, adjusting resource/client paths fixes the issue.
@michalvavrik michalvavrik force-pushed the feature/fix-service-discovery-tests branch from 6b7fb40 to c149dcc Compare June 16, 2022 19:48
@michalvavrik michalvavrik merged commit c276567 into quarkus-qe:main Jun 16, 2022
@michalvavrik michalvavrik deleted the feature/fix-service-discovery-tests branch June 16, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants