Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider env/* labels as triaging labels #110

Closed
gsmet opened this issue Jun 9, 2021 · 0 comments · Fixed by #122
Closed

Do not consider env/* labels as triaging labels #110

gsmet opened this issue Jun 9, 2021 · 0 comments · Fixed by #122
Assignees

Comments

@gsmet
Copy link
Member

gsmet commented Jun 9, 2021

When we triage an issue, if we didn't add any label, we add the needs-triage one.

The problem is that we should only consider area/* labels in this as env/* labels are not enough to properly triage something.

So we should change the behavior to add the needs-triage label if we didn't add any area/* labels.

See quarkusio/quarkus#17755 for an example of the wrong behavior.

The rule is the following: https://github.com/quarkusio/quarkus-github-bot/blob/main/src/main/java/io/quarkus/bot/TriageIssue.java

Luke1432 added a commit to Luke1432/quarkus-github-bot that referenced this issue Jul 9, 2021
@gsmet gsmet closed this as completed in #122 Jul 9, 2021
Luke1432 added a commit to Luke1432/quarkus-github-bot that referenced this issue Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants