-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExceptionMapper to security-openid-connect-client-quickstart #1108
Add ExceptionMapper to security-openid-connect-client-quickstart #1108
Conversation
@@ -11,6 +11,10 @@ quarkus.oidc-client.grant.type=password | |||
quarkus.oidc-client.grant-options.password.username=alice | |||
quarkus.oidc-client.grant-options.password.password=alice | |||
|
|||
org.acme.security.openid.connect.client.ProtectedResourceOidcClientFilter/mp-rest/url=http://localhost:8081/protected | |||
org.acme.security.openid.connect.client.ProtectedResourceTokenPropagationFilter/mp-rest/url=http://localhost:8081/protected | |||
%prod.port=8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsmet Guillaume, is it a good way to handle client ports such that it works in dev, test and prod modes ? I've verified, it works, but may be there is a neater way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to just use ${quarkus.http.port}
I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ladicek Thanks, I'll give it a try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ladicek No, it does not work, tests fail as the test endpoints are on 8081
but quarkus.http.port
is 8080
by default.
I guess I can set quarkus.http.port
to 8081
in pom.xml but I'm not sure if it will be a simpler approach ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I thought quarkus.http.port
is 8081 in the test
profile. I swear I saw something like this before, but not sure exactly...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ladicek No problems, thanks for the idea, it makes sense to have it defaulting to 8081
, may be it was done indirectly by assigning it to quarkus.http.test-port
in some demo configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's not pretty, we probably have to improve on this but it will do for now.
No description provided.