Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixes #4495] - Quarkus Keycloak Authorization Extension #331

Closed
wants to merge 1 commit into from
Closed

[fixes #4495] - Quarkus Keycloak Authorization Extension #331

wants to merge 1 commit into from

Conversation

pedroigor
Copy link
Contributor

No description provided.

@pedroigor pedroigor mentioned this pull request Oct 22, 2019
Merged
cescoffier
cescoffier requested changes Oct 28, 2019
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need tests and native tests.
A README would be quite nice too to explain how to use the quickstarts.

keycloak-authorization/src/main/resources/application.properties Outdated

# DEBUG console logging
quarkus.log.console.enable=true
#quarkus.log.console.format=%d{HH:mm:ss} %-5p [%c{2.}]] (%t) %s%e%n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop the commented lines?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or explain the purpose.

@cescoffier
Copy link
Member

I've merged it manually because of the "BIG RENAMING".

@cescoffier
Copy link
Member

Thanks, BTW, it looks great now!

@cescoffier cescoffier closed this Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedroigor @cescoffier