Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenTelemetry quickstart #872

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Add OpenTelemetry quickstart #872

merged 1 commit into from
Jun 3, 2021

Conversation

kenfinnigan
Copy link
Member

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

@kenfinnigan kenfinnigan requested a review from radcortez May 27, 2021 16:08
@kenfinnigan kenfinnigan mentioned this pull request May 27, 2021
Closed
radcortez
radcortez reviewed May 27, 2021
View reviewed changes
Copy link
Member

@radcortez radcortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have Jaeger running to see the results? Maybe we can add an in-memory exporter to show in the test?

@kenfinnigan
Copy link
Member Author

We could do that.

I'd just followed the same pattern as the opentracing guide, where the Docker container for Jaeger is only in the guide.

I don't have a preference either way

@radcortez
Copy link
Member

Sounds good. Maybe we can add Jaeger as a Dev Service later.

@kenfinnigan kenfinnigan marked this pull request as ready for review June 2, 2021 18:37
@kenfinnigan kenfinnigan mentioned this pull request Jun 2, 2021
Merged
@gsmet gsmet merged commit 1a619dd into quarkusio:development Jun 3, 2021
@kenfinnigan kenfinnigan deleted the opentelemetry branch July 2, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radcortez radcortez radcortez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenfinnigan @radcortez @gsmet