Skip to content

Commit 21042ba

Browse files
authored
Merge pull request #25877 from mkouba/contextdatamap-generics
ContextDataMap - get rid of raw types
2 parents 9b4b897 + e63bce9 commit 21042ba

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/ContextDataMap.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import java.util.Collections;
99
import java.util.HashMap;
1010
import java.util.HashSet;
11+
import java.util.List;
1112
import java.util.Map;
1213
import java.util.Objects;
1314
import java.util.Set;
@@ -38,7 +39,7 @@ final class ContextDataMap implements Map<String, Object> {
3839

3940
private Map<String, Object> getDelegateForRead() {
4041
if (delegate == null) {
41-
return Collections.EMPTY_MAP;
42+
return Collections.emptyMap();
4243
} else {
4344
return delegate;
4445
}
@@ -81,7 +82,7 @@ public Set<Map.Entry<String, Object>> entrySet() {
8182
if (delegate == null) {
8283
return Collections.singleton(firstEntry);
8384
} else {
84-
HashSet entries = new HashSet(delegate.size() + 1);
85+
Set<Map.Entry<String, Object>> entries = new HashSet<>(delegate.size() + 1);
8586
entries.addAll(delegate.entrySet());
8687
entries.add(firstEntry);
8788
return entries;
@@ -106,15 +107,15 @@ public Set<String> keySet() {
106107
if (delegate == null) {
107108
return Collections.singleton(ArcInvocationContext.KEY_INTERCEPTOR_BINDINGS);
108109
} else {
109-
HashSet set = new HashSet(delegate.size() + 1);
110+
Set<String> set = new HashSet<>(delegate.size() + 1);
110111
set.addAll(delegate.keySet());
111112
set.add(ArcInvocationContext.KEY_INTERCEPTOR_BINDINGS);
112113
return set;
113114
}
114115
}
115116

116117
@Override
117-
public void putAll(Map m) {
118+
public void putAll(Map<? extends String, ? extends Object> m) {
118119
if (m.containsKey(ArcInvocationContext.KEY_INTERCEPTOR_BINDINGS)) {
119120
throw new IllegalArgumentException(
120121
"Not allowed to put key '" + ArcInvocationContext.KEY_INTERCEPTOR_BINDINGS + "' in the context data map");
@@ -140,11 +141,11 @@ public int size() {
140141
}
141142

142143
@Override
143-
public Collection values() {
144+
public Collection<Object> values() {
144145
if (delegate == null) {
145146
return Collections.singleton(interceptorBindings);
146147
} else {
147-
ArrayList list = new ArrayList(delegate.size() + 1);
148+
List<Object> list = new ArrayList<>(delegate.size() + 1);
148149
list.addAll(delegate.values());
149150
list.add(interceptorBindings);
150151
return list;

0 commit comments

Comments
 (0)