ContextDataMap - get rid of raw types #25877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicek
approved these changes
May 31, 2022
Contributor
Ladicek
left a comment
Ladicek
left a comment
There was a problem hiding this comment.
Looks OK, but I guess the use of implementation types (HashSet or ArrayList) instead of interfaces (Set or List) might have been intentional, to avoid interface method lookups in a performance sensitive piece of code (invokevirtual vs. invokeinterface).
manovotn
approved these changes
May 31, 2022
Contributor
manovotn
left a comment
manovotn
left a comment
There was a problem hiding this comment.
LGTM, thanks for noticing this
Member
right that's indeed my "preferred style" :) But it shouldn't matter here, it's ok. |
Sanne
approved these changes
May 31, 2022
mkouba
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #25835