Merge pull request #46198 from franz1981/grpc_netty_client

Grpc netty client improvements
quarkusio · Mar 10, 2025 · d3a8d95 · d3a8d95
2 parents 58ff745 + bf12ff2
commit d3a8d95
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/...ns/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/config/GrpcClientConfiguration.java b/...ns/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/config/GrpcClientConfiguration.java
@@ -24,6 +24,12 @@ public interface GrpcClientConfiguration {
     @WithDefault("false")
     boolean useQuarkusGrpcClient();
 
+    /**
+     * Use Vert.x event loop(s) for gRPC client, if it's using the previous Java gRPC support.
+     */
+    @WithDefault("true")
+    boolean useVertxEventLoop();
+
     /**
      * Configure XDS usage, if enabled.
      */

diff --git a/extensions/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/supports/Channels.java b/extensions/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/supports/Channels.java
@@ -45,6 +45,7 @@
 import io.grpc.netty.GrpcSslContexts;
 import io.grpc.netty.NegotiationType;
 import io.grpc.netty.NettyChannelBuilder;
+import io.netty.channel.socket.nio.NioSocketChannel;
 import io.netty.handler.ssl.SslContext;
 import io.netty.handler.ssl.SslContextBuilder;
 import io.quarkus.arc.Arc;
@@ -206,8 +207,21 @@ public static Channel createChannel(String name, Set<String> perClientIntercepto
                 builder.defaultServiceConfig(map);
             }
 
-            if (builder instanceof NettyChannelBuilder) {
+            if (config.useVertxEventLoop() && builder instanceof NettyChannelBuilder) {
                 NettyChannelBuilder ncBuilder = (NettyChannelBuilder) builder;
+                // just use the existing Vertx event loop group, if possible
+                Vertx vertx = container.instance(Vertx.class).get();
+                // only support NIO for now, since Vertx::transport is not exposed in the API
+                if (vertx != null && vertx.isNativeTransportEnabled()) {
+                    // see https://github.com/eclipse-vertx/vert.x/pull/5292
+                    boolean reuseNettyAllocators = Boolean.getBoolean("vertx.reuseNettyAllocators");
+                    if (reuseNettyAllocators) {
+                        // let Netty Grpc to re-use the default Netty allocator as well
+                        System.setProperty("io.grpc.netty.useCustomAllocator", "false");
+                    }
+                    ncBuilder = ncBuilder.eventLoopGroup(vertx.nettyEventLoopGroup())
+                            .channelType(NioSocketChannel.class);
+                }
                 builder = ncBuilder
                         // clients are intercepted using the IOThreadClientInterceptor interceptor which will decide on which
                         // thread the messages should be processed.
@@ -395,6 +409,11 @@ public boolean useQuarkusGrpcClient() {
                 return false;
             }
 
+            @Override
+            public boolean useVertxEventLoop() {
+                return true;
+            }
+
             @Override
             public ClientXds xds() {
                 return null;