Merge pull request #537 from emmanuelbernard/536

Fail explicitly if no `persistence.xml` is present and no dialect can be guessed from the driver
quarkusio · Jan 16, 2019 · e2e104a · e2e104a
2 parents c47abe5 + cc0cab8
commit e2e104a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/...sions/jpa/deployment/src/main/java/org/jboss/shamrock/jpa/HibernateResourceProcessor.java b/...sions/jpa/deployment/src/main/java/org/jboss/shamrock/jpa/HibernateResourceProcessor.java
@@ -275,7 +275,10 @@ private Optional<String> guessDialect(Optional<String> driver) {
         if ( resolvedDriver.contains("org.mariadb.jdbc.Driver")) {
             return Optional.of(MariaDB103Dialect.class.getName());
         }
-        return Optional.empty();
+        String error = driver.isPresent() ?
+                "Hibernate extension could not guess the dialect from the driver '" + resolvedDriver + "'. Add an explicit 'shamrock.hibernate.dialect' property." :
+                "Hibernate extension cannot guess the dialect as no JDBC driver is specified by 'shamrock.datasource.driver'";
+        throw new ConfigurationError(error);
     }
 
     private void enhanceEntities(final KnownDomainObjects domainObjects, BuildProducer<BytecodeTransformerBuildItem> transformers) {