MicroProfile Rest Client - Multiple multipart files

[vinimdev]

Guys, I am using Quarkus 3.8.3 and the MicroProfile Rest Client to make HTTP requests, but I am having problems with uploading multiple files.

I am using the client in this way:

@POST
@Consumes(MediaType.MULTIPART_FORM_DATA)
Response postRespbuilderWithFiles(@HeaderParam(AUTHORIZATION) String authorization,
                                  @HeaderParam(CANAL_ATENDIMENTO) String canalAtendimento,
                                  @HeaderParam(EMAIL) String email,
                                  @HeaderParam(USUARIO) String usuario,
                                  @RestQuery MultivaluedMap<String, ?> parametros,
                                  QuarkusMultipartForm files);

and assembling the files in this way:

public QuarkusMultipartForm buildClientMultipartForm(List<FileUpload> files) {
        QuarkusMultipartForm multiPartForm = new QuarkusMultipartForm();
        files.forEach(fu -> multiPartForm.binaryFileUpload("files", fu.fileName(), fu.filePath().toString(), fu.contentType()));
        return multiPartForm;
}

This has worked correctly when there's only one file, but when there are multiple files, I receive from my other receiving application (Spring or Quarkus) that the body is malformed:

Caused by: org.springframework.web.multipart.MultipartException: Failed to parse multipart servlet request; nested exception is java.lang.RuntimeException: java.io.IOException: io.undertow.util.MalformedMessageException
	at org.springframework.web.multipart.support.StandardMultipartHttpServletRequest.handleParseFailure(StandardMultipartHttpServletRequest.java:127)
	at org.springframework.web.multipart.support.StandardMultipartHttpServletRequest.parseRequest(StandardMultipartHttpServletRequest.java:115)
	at org.springframework.web.multipart.support.StandardMultipartHttpServletRequest.<init>(StandardMultipartHttpServletRequest.java:88)
	at org.springframework.web.multipart.support.StandardServletMultipartResolver.resolveMultipart(StandardServletMultipartResolver.java:122)
	at org.springframework.web.servlet.DispatcherServlet.checkMultipart(DispatcherServlet.java:1209)
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1043)
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:964)
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)
	... 51 common frames omitted

How can I solve this problem with multiple files?

[quarkus-bot[bot]]

/cc @cescoffier (rest-client), @geoand (rest-client)

[geoand]

Something is definitely not correct as your application seems to be a Spring application judging from the stacktrace

[vinimdev]

The error log is from the receiving application; the originating application (Quarkus) does not give an error when sending the files. It's the receiver that cannot interpret the files when there is more than one file. I tested with a Quarkus application as the receiver, and the error is of the same type.

[vinimdev]

Here's how it arrives at the receiving application:

Request with more than one file:

Request with just one file:

[geoand]

I'd need two sample application (client and server) in order to be able to tell you more

[vinimdev]

Here's an example of the Quarkus app, what I did was create a replica and call Quarkus itself and it gives the mentioned error.

And for Spring, the error occurs when using Undertow.

https://github.com/vinimdev/quarkus-example

[geoand]

Thanks, I'll soon have a look

[vinimdev]

Example spring with undertow (error)

https://github.com/vinimdev/spring-undertow-exaple

[geoand]

Take a look at #39770 for an explanation of the problem.

For now what you can do is configure

quarkus.rest-client.multipart-post-encoder-mode=HTML5

but when that PR is merged and included in a release, you will be able to do:

quarkus.rest-client.spring-multipart.multipart-post-encoder-mode=HTML5

[rsvoboda]

HTMT5 => HTML5 @geoand ?

[geoand]

Good point!

[rsvoboda]

I have updated #39751 (reply in thread) comment

[geoand]

#39751 (reply in thread) is the final answer :)

[geoand]

I tried it and it worked for me on your app

[vinimdev]

Could it be because I'm using new builder? Is there a way to set this property programmatically?

public <T> T createProduceClient(String url, Class<T> client, Long connectTimeout, Long readTimeout) {
      return RestClientBuilder.newBuilder()
              .baseUri(URI.create(url))
              .register(new ResponseSizeLimitFilter(responseSizeLimit))
                .register(new HeaderRequestFilter(userContext))
                .connectTimeout(connectTimeout)
                .readTimeout(readTimeout)
                .property("microprofile.rest.client.disable.default.mapper", true)
                .build(client);
    }

[vinimdev]

Got it this way @geoand:

Thanks for the help, mate!

.property(QuarkusRestClientProperties.MULTIPART_ENCODER_MODE, PausableHttpPostRequestEncoder.EncoderMode
                        .valueOf("HTML5"))

[geoand]

Right, I was about to say you can do that, but I will improve my PR so you don't have to do that.

[geoand]

Once that is in you will be able to do builder.multipartPostEncoderMode("HTML5")