Quarkus 3.13.0: Maven builds use up to 4 times more resources than with 3.12.3

[admanzoni]

Hi there!

I have just upgraded to from 3.12.3 to 3.13.0 and realized than the Maven build use up to 4 times more memory than before.
Has anyone noticed the same behaviour ?

[EDIT]
I did follow the recommendation and used WithTestResource instead of QuarkusTestResource.
By using QuarkusTestResource (deprecated way), my build use around 1/1.5 GB of memory
By using WithTestResource, my build use 6GB

[quarkus-bot[bot]]

/cc @quarkusio/devtools (maven)

[aloubyansky]

@edeandrea fyi

[edeandrea]

All the new annotation does is change the default of restrictToAnnotatedClass from false to true.

I think this means that the test resource, by default, is bound only to the single test class rather than all test classes.

I'd be curious if you see the same thing if you use @QuarkusTestResource(restrictToAnnotatedClass=true)

My guess is that the behavior would be the same. Nothing else changed really

[gsmet]

Do we properly clean up the resources after the class is handled?

[edeandrea]

Do we properly clean up the resources after the class is handled?

I honestly don't know. I didn't write any of the code that handles this. All I did was add the new annotation into the workflow that already existed.

[gsmet]

Well, sure, but changing the default means we need to be extra careful.

[edeandrea]

The way it was before was super confusing. Test resources (and any config a test resource may have injected) is available for all test classes, even if the test class wasn't annotated. The change itself was spawned by https://x.com/cowtowncoder/status/1736913697426338262

I'd be curious if the same observation is noted when using @QuarkusTestResource(restrictToAnnotatedClass=true). You can always use @WithTestResource(restrictAnnotatedClass=false) to revert to previous behavior.

[maxandersen]

Do you have a reproducer so we can be sure what issue/difference you are seeing?

[maxandersen]

So just to be clear - we didn't change the default - a new annotation was introduced.

You upgraded from 3.12 to 3.13 AND moved to the new @withtestresource, correct ?

[maxandersen]

Ah you updated the description.

But yeah @edeandrea and @gsmet a default that costs 4x memory doesn't sound good.

Is this expected ? Fixable?

[maxandersen]

How many test classes/methods do you have ? Curious if few, many, alot, ... :)

[admanzoni]

In that module, we have 17 test classes and between 6-7 methods each.
The test resource is a Keycloak mock server.

[edeandrea]

@maxandersen #37853 is where this was discussed/implemented. @QuarkusTestResource and the new @WithTestResource do the same thing. The only difference is the default value of restrictToAnnotatedClass flips from false with @QuarkusTestResource and is now true with @WithTestResource.

Because @QuarkusTestResource(restrictToAnnotatedClass=true) shows this difference, then something with the way restrictToAnnotatedClass=true works is most likely not right. I have no idea how that works. That pre-existed the new @WithTestResource annotation.

[gsmet]

@admanzoni would you have the ability to test #42304 ?

[gsmet]

@admanzoni but first, could you downgrade your application to 3.12.3 and just update your @QuarkusTestResource with restrictAnnotatedClass=true and see how it behaves?

[admanzoni]

Sure, by downgrading to 3.12.3 and with @QuarkusTestResource(value = KeycloakServerMock.class, restrictToAnnotatedClass = true), I also observe a increase of the memory consumption (about the same ratio x4)

[gsmet]

OK, thanks. So it's not my work who caused the issue, thanks for checking. I'll have a deeper look next week.

[mschorsch]

Same issue: #42303 (comment)

[geoand]

#42303 has been fixed - it was a Keycloak DevService specific issue

[edeandrea]

Looks like another issue related? #42365

[edeandrea]

I ran the same test - downgraded to Quarkus 3.12.3 and switched to @QuarkusTestResource an tried with both true and false for restrictToAnnotatedClass.

#42365 (comment)