-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 12 build fails: Could not initialize class org.jboss.classfilewriter.DefaultClassFactory #1534
Comments
Issue is still present with Quarkus 0.12.0
|
@stuartwdouglas @dmlloyd I see there is now a Is there any plan to fix that? (with Quarkus being bleeding edge, there's a good chance people will play with it with the latest JDKs) |
I believe that the preferred solution is still to drop jboss-classfilewriter but I don't think anyone is working that change at the moment. |
Just running into this with JDK 13; reading the discussion in #819, would it perhaps make sense to use ByteBuddy for that proxy generation? |
We already have a number of bytecode creation tools at our disposal. I'd say that we should use Gizmo to generate these proxies; it shouldn't be too hard to do. |
Happened to come across the same issue with JRE 12, but the issue is solved with JRE 8. |
@dmlloyd @stuartwdouglas any plans to make Quarkus run on java 12 and java 13 ? |
Some day, for sure, because we'll want to support the next LTS version. But supporting 11 is a prerequisite. |
I just want to support what was written in #1534 (comment):
I use JDK 12 (with |
The problem stil exists in 0.21.1 version |
Yes, it does, we haven't changed anything in this regard. The idea is that we should get rid of the JBoss Invocation dependency which uses JBoss ClassFileWriter:
It's used in As they are build time code and test infrastructure, I think we can use a dynamic proxy. It will be a bit more code but it should work OK. @gwenneg interested in this one? |
@gsmet Yes, I'll gladly help on this one. I'm not sure there will be a PR ready for |
@gwenneg Is this something you started looking into? If not, I think it's something I can potentially get in before the next release |
@geoand I took a quick look at it and didn't find how to solve this with dynamic proxies only, then I started looking for a way to do it with Gizmo but I didn't spend much time on it and won't be able to until |
Thanks for the info. I'll take a look at a Gizmo based solution, hopefully I can have it in time for |
Now that I think about it more it might not be wise to get such a change in so close to release even if I do have a proper replacement. |
This is first step to allow the project to build on JDK 12+ Relates to: quarkusio#1534
I opened #3810 that allows for removing |
This makes sense for Quarkus where the ClassLoader is under our control. The benefit is that proxy classes can be generated no matter what JDK version is being used (so now proxies can be generated even in JDK 12+) Fixes: quarkusio#1534
This makes sense for Quarkus where the ClassLoader is under our control. The benefit is that proxy classes can be generated no matter what JDK version is being used (so now proxies can be generated even in JDK 12+) Fixes: quarkusio#1534
#3906 should take care of the issue for good |
This issue looks very similar to #819, but it is a different class (from probably the same library):
Running our build with Quarkus 0.11.0 on JDK 12 fails:
Could not initialize class org.jboss.classfilewriter.DefaultClassFactory
You will find the full build-output here: https://travis-ci.org/mapstruct/mapstruct-examples/jobs/506375906 (I am not sure if these logs will be discarded after time).
Java version details:
In case you need more information please let me know.
(nevertheless, thank you very much for Quarkus - just did a few tests with the library and it looks gorgeous!)
The text was updated successfully, but these errors were encountered: