-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors reported to sentry.io result in an <unlabelled event> #15623
Comments
/cc @evanchooly, @geoand |
I initially forgot to mention, that this issue occurs only with the native image. |
I took some time and played with the reflection recorder. After adding the following entries in reflection-config.json, the basic error reporting finally worked. I am not certain though, if this covers all possible cases. Looks like the sentry-java library is not ready for native execution yet: [
{
"name":"io.sentry.Breadcrumb",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.SentryBaseEvent",
"allDeclaredFields":true
},
{
"name":"io.sentry.SentryEvent",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.SentryValues",
"allDeclaredFields":true
},
{
"name":"io.sentry.protocol.DebugImage",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.DebugMeta",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.Mechanism",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.Message",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.Request",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.SdkInfo",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.SdkVersion",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.SentryException",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.SentryPackage",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.SentryStackFrame",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.SentryStackTrace",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.SentryThread",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"name":"io.sentry.protocol.User",
"allDeclaredFields":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
}
]
|
FYI we are working on it on the Sentry SDK side: getsentry/sentry-java#1329 |
@ia3andy any idea why we dont have this issue - just a feature of sentry we didnt use and thus wasnt noticed ? |
Fixes quarkusio#15623 Based on the work of u6f6o and Maciej Walkowiak
In the meantime, I think we should fix it for 1.13. I implemented the rules here while we wait for the upgrade to a Sentry version including them: #15847 . |
@u6f6o if you have the time to check the PR fixes your issue, that would be very nice. https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#checking-an-issue-is-fixed-in-main might be of help (except you need to target my PR branch instead of main). |
In code.quarkus.io we are not using native, so I guess this was never actually tested in native. @maciejwalkowiak it would be nice if we add some integration tests to make sure events are sent correctly (native & non native), any idea how we could do it, mocking some Sentry components maybe? |
You can mock the |
@gsmet : I tested it as well, it worked for me. Thx for the fix! |
Fixes quarkusio#15623 Based on the work of u6f6o and Maciej Walkowiak (cherry picked from commit 908c87f)
In our setup, we use sentry.io to report errors. This setup seems to be currently broken for our quarkus services though. Errors reported to sentry.io do not show any actual content but are marked as unlabelled events:
Expected behavior
Errors in sentry should contain stacktraces, error messages etc.
Actual behavior
All errors reported result in unlabelled events with actual no content.
Configuration
gradle.properties:
dependencies from build.gradle
Environment (please complete the following information):
mvnw --version
orgradlew --version
): Gradle 6.3The text was updated successfully, but these errors were encountered: