Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option quarkus.websocket.dispatch-to-worker=true doesn't work anymore in Quarkus 1.13 #17571

Closed
Feavy opened this issue May 31, 2021 · 2 comments · Fixed by #17632
Closed

Option quarkus.websocket.dispatch-to-worker=true doesn't work anymore in Quarkus 1.13 #17571

Feavy opened this issue May 31, 2021 · 2 comments · Fixed by #17632
Labels
area/websockets kind/bug Something isn't working
Milestone

Comments

@Feavy
Copy link

Feavy commented May 31, 2021

Describe the bug

Setting the value of quarkus.websocket.dispatch-to-worker to true doesn't change anything. WebSockets remain on vert.x-eventloop threads.

Expected behavior

WebSockets should be executed on executor threads (like in Quarkus 1.11).

Actual behavior

WebSockets are executed on vert.x-eventloop threads instead of executor ones.

To Reproduce

  1. Start with Quarkus 1.13 WebSockets example code.
  2. Add a log line in SupersonicChatSocket#onOpen like LOG.info("I am a WebSocket!");
  3. Launch the program, go to http://localhost:8080, and connect with a username.
  4. See in the console 2021-06-01 01:32:50,570 INFO [org.acm.und.SupersonicChatSocket] (vert.x-eventloop-thread-11) I'm a WebSocket! notice vert.x-eventloop-thread-11
  5. Now, set the property quarkus.websocket.dispatch-to-worker=true in application.properties
  6. Redo step 3 and 4 and observe that it still logs a vert.x-eventloop-thread-X thread.

You can do the same thing with Quarkus 1.11.3.Final, after setting the option to true you will see WebSocket is executed on an executor thread like it should be:

2021-06-01 01:30:27,083 INFO [org.acm.und.SupersonicChatSocket] (executor-thread-198) I am a WebSocket!

@Feavy Feavy added the kind/bug Something isn't working label May 31, 2021
@Feavy Feavy changed the title Option quarkus.websockets.dispatch-to-worker=true doesn't work anymore in Quarkus 1.13 Option quarkus.websocket.dispatch-to-worker=true doesn't work anymore in Quarkus 1.13 Jun 1, 2021
@Feavy
Copy link
Author

Feavy commented Jun 2, 2021

I think the problem came with this PR #15068

gsmet added a commit to gsmet/quarkus that referenced this issue Jun 2, 2021
Also use the executor included in the container info even if the code
was working ok.

Fixes quarkusio#17571
@gsmet
Copy link
Member

gsmet commented Jun 2, 2021

Yeah, I think #17632 should fix it.

@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 3, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.CR3 Jun 3, 2021
gsmet added a commit to gsmet/quarkus that referenced this issue Jun 3, 2021
Also use the executor included in the container info even if the code
was working ok.

Fixes quarkusio#17571

(cherry picked from commit 01ba4c0)
@gsmet gsmet modified the milestones: 2.0.0.CR3, 1.13.7.Final Jun 7, 2021
gsmet added a commit to gsmet/quarkus that referenced this issue Jun 7, 2021
Also use the executor included in the container info even if the code
was working ok.

Fixes quarkusio#17571

(cherry picked from commit 01ba4c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/websockets kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants