Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarkus bundles generated projects with maven wrapper 3.6.3 #17668

Closed
kshpak opened this issue Jun 3, 2021 · 3 comments · Fixed by #17688
Closed

Quarkus bundles generated projects with maven wrapper 3.6.3 #17668

kshpak opened this issue Jun 3, 2021 · 3 comments · Fixed by #17688
Labels
area/maven kind/bug Something isn't working
Milestone
1.13.7.Final

Comments

@kshpak
Copy link
Contributor

kshpak commented Jun 3, 2021

Describe the bug

Project from code.quarkus.io and projects generated via mvn io.quarkus:quarkus-maven-plugin:1.13.6.Final:create still bundles with maven wrapper in version 3.6.3

According to #16249 the shift to maven 3.8.1 was done

Expected behavior

Maven wrapper 3.8.1 is bundled

Quarkus version or git rev

1.13.x
@kshpak kshpak added the kind/bug Something isn't working label Jun 3, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 3, 2021

/cc @quarkusio/devtools

@famod
Copy link
Member

famod commented Jun 3, 2021 •
edited
Loading

I suppose something has to be changed in https://github.com/quarkusio/code.quarkus.io @ia3andy @gsmet?
I'm not familiar with that repo.

geoand added a commit to geoand/quarkus that referenced this issue Jun 4, 2021
@geoand
Use version 3.8.1 in the generated projects
57a132a 
Fixes: quarkusio#17668
@geoand geoand mentioned this issue Jun 4, 2021
Merged
@geoand
Copy link
Contributor

geoand commented Jun 4, 2021

Would #17688 not do the trick?

@kshpak kshpak mentioned this issue Jun 4, 2021
Merged
geoand added a commit that referenced this issue Jun 7, 2021
@geoand
Merge pull request #17688 from geoand/#17668
09a493d 
Use version 3.8.1 in the generated projects
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 7, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 1.13.7.Final Jun 7, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jun 7, 2021
@geoand @gsmet
Use version 3.8.1 in the generated projects
6d10f77 
Fixes: quarkusio#17668
(cherry picked from commit 57a132a)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jun 7, 2021
@geoand @gsmet
Use version 3.8.1 in the generated projects
644d57b 
Fixes: quarkusio#17668
(cherry picked from commit 57a132a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/maven kind/bug Something isn't working
Projects
None yet
Milestone
1.13.7.Final
Development

Successfully merging a pull request may close this issue.

Use Maven version 3.8.1 in the generated projects geoand/quarkus
4 participants
@gsmet @geoand @famod @kshpak