Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuarkusIntegrationTest docker run, does not clean container after timeout #17737

Closed
bdevreugd-vialis opened this issue Jun 7, 2021 · 2 comments · Fixed by #17757
Closed

QuarkusIntegrationTest docker run, does not clean container after timeout #17737

bdevreugd-vialis opened this issue Jun 7, 2021 · 2 comments · Fixed by #17757

Comments

@bdevreugd-vialis
Copy link
Contributor

If the docker run process takes more then 10 seconds to fully startup Quarkus, the extension will forcibly destroy the process. If the container, however, was started, it won't be cleaned up, leaving it running on the docker daemon.

If you use the --cidfile parameter on docker run, then at the end of the process you can check if that file exists and if so remove the container with docker rm -f {cidfile_contents}

These dangling containers also arrived with issue #17565, so I would prefer the cidfile cleanup over changing destroyForcibly to destroy, that way all issues that could arrive will never result in dangling containers.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 7, 2021

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Jun 7, 2021

I'll check it out

geoand added a commit to geoand/quarkus that referenced this issue Jun 8, 2021
…ate normally

This is especially useful when launching a docker container because
the '--rm' flag of 'docker run' takes only if the process is terminated
normally

Fixes: quarkusio#17737
gastaldi added a commit that referenced this issue Jun 8, 2021
Give processes launched by @QuarkusIntegrationTest a chance to terminate normally
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 8, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 10, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jun 10, 2021
…ate normally

This is especially useful when launching a docker container because
the '--rm' flag of 'docker run' takes only if the process is terminated
normally

Fixes: quarkusio#17737
(cherry picked from commit de12100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants