Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typesafe GraphQL client does not see NonNull annotations #18194

Closed
jmartisk opened this issue Jun 28, 2021 · 2 comments · Fixed by #18297
Closed

Typesafe GraphQL client does not see NonNull annotations #18194

jmartisk opened this issue Jun 28, 2021 · 2 comments · Fixed by #18297
Assignees
@jmartisk
Labels
area/graphql area/smallrye kind/bug Something isn't working
Milestone
2.0.1.Final

Comments

@jmartisk
Copy link
Contributor

In native mode, if the @GraphQLClientApi contains methods whose parameters are @org.eclipse.microprofile.graphql.NonNull, the typesafe client doesn't see the annotation at runtime so it assumes a wrong GraphQL type, so a query might be rejected by the server, with something like

- Validation error of type VariableTypeMismatch: Variable type 'String' doesn't match expected type 'String!' @ 'all' [(1:38)] {classification=ValidationError})
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 28, 2021

/cc @phillip-kruger

@jmartisk jmartisk self-assigned this Jun 28, 2021
@jmartisk
Copy link
Contributor Author

jmartisk commented Jul 1, 2021

This will be fixed by upgrading SmallRye GraphQL to 1.2.6

@jmartisk jmartisk mentioned this issue Jul 1, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 4, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.1.Final Jul 5, 2021
geoand added a commit to geoand/quarkus that referenced this issue Jul 22, 2021
@geoand
Use testcontainers networking capabilities when using @QuarkusIntegra…
fb068d3 
…tionTest + DevServices

This is done in order to get us off of host networking (which only works on Linux).
The way this works is that when @QuarkusIntegrationTest is meant to launch a container
and DevServices are needed, a build item is pushed into the build that forces
the DevServices to launch in TestContainers' SHARED Network.
The id of network is then used when launching the application as a container.

Fixes: quarkusio#18194
@geoand geoand mentioned this issue Jul 22, 2021
Merged
geoand added a commit to geoand/quarkus that referenced this issue Jul 23, 2021
@geoand
Use testcontainers networking capabilities when using @QuarkusIntegra…
3f36649 
…tionTest + DevServices

This is done in order to get us off of host networking (which only works on Linux).
The way this works is that when @QuarkusIntegrationTest is meant to launch a container
and DevServices are needed, a build item is pushed into the build that forces
the DevServices to launch in TestContainers' SHARED Network.
The id of network is then used when launching the application as a container.

Fixes: quarkusio#18194
geoand added a commit to geoand/quarkus that referenced this issue Jul 28, 2021
@geoand
Use testcontainers networking capabilities when using @QuarkusIntegra…
a41ecd0 
…tionTest + DevServices

This is done in order to get us off of host networking (which only works on Linux).
The way this works is that when @QuarkusIntegrationTest is meant to launch a container
and DevServices are needed, a build item is pushed into the build that forces
the DevServices to launch in TestContainers' SHARED Network.
The id of network is then used when launching the application as a container.

Fixes: quarkusio#18194
geoand added a commit to geoand/quarkus that referenced this issue Jul 28, 2021
@geoand
Use testcontainers networking capabilities when using @QuarkusIntegra…
a4f88e5 
…tionTest + DevServices

This is done in order to get us off of host networking (which only works on Linux).
The way this works is that when @QuarkusIntegrationTest is meant to launch a container
and DevServices are needed, a build item is pushed into the build that forces
the DevServices to launch in TestContainers' SHARED Network.
The id of network is then used when launching the application as a container.

Fixes: quarkusio#18194
geoand added a commit to geoand/quarkus that referenced this issue Jul 28, 2021
@geoand
Use testcontainers networking capabilities when using @QuarkusIntegra…
e2c821a 
…tionTest + DevServices

This is done in order to get us off of host networking (which only works on Linux).
The way this works is that when @QuarkusIntegrationTest is meant to launch a container
and DevServices are needed, a build item is pushed into the build that forces
the DevServices to launch in TestContainers' SHARED Network.
The id of network is then used when launching the application as a container.

Fixes: quarkusio#18194
geoand added a commit to geoand/quarkus that referenced this issue Jul 28, 2021
@geoand
Use testcontainers networking capabilities when using @QuarkusIntegra…
7fbf437 
…tionTest + DevServices

This is done in order to get us off of host networking (which only works on Linux).
The way this works is that when @QuarkusIntegrationTest is meant to launch a container
and DevServices are needed, a build item is pushed into the build that forces
the DevServices to launch in TestContainers' SHARED Network.
The id of network is then used when launching the application as a container.

Fixes: quarkusio#18194
@frisket frisket mentioned this issue Jan 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartisk jmartisk

Labels
area/graphql area/smallrye kind/bug Something isn't working
Projects
None yet
Milestone
2.0.1.Final
Development

Successfully merging a pull request may close this issue.

SmallRye GraphQL 1.2.7 jmartisk/quarkus
2 participants
@jmartisk @gsmet