Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable disabling Kubernetes extension processing completely #34094

Open
metacosm opened this issue Jun 16, 2023 · 3 comments
Open

Enable disabling Kubernetes extension processing completely #34094

metacosm opened this issue Jun 16, 2023 · 3 comments
Labels
area/kubernetes kind/enhancement New feature or request

Comments

@metacosm
Copy link
Contributor

metacosm commented Jun 16, 2023 •
edited
Loading

Description

Much of the time, it is unnecessary to generate Kubernetes manifests on every build because not every build is meant to be deployed or even deployable. Very often, information is actually missing to generate correct manifests. While people could only activate the extension based on a profile, it might be interesting to be able to disable the processing / generation performed by the extension via a configuration property.
An implementation of such feature was originally provided by #33707 before deciding that a better solution should be designed. See that issue for some discussions around the potential issues.

/cc @iocanel @geoand @maxandersen
@metacosm metacosm added the kind/enhancement New feature or request label Jun 16, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 16, 2023

/cc @Sgitario (kubernetes), @geoand (kubernetes), @iocanel (kubernetes)

@maxandersen
Copy link
Member

there are two aspects afaics:

  1. should kube resources be generated for quarkus dev?

  2. should there be option to turn on/off generation separate from enable/disable the extension

#1 I think is a bug and shuold not generate the resources on every restart or even ever using quarkus dev

#2 is mainly the question if we need something besides .enabled=false for the extension like we have for others that just make it be fully ignored ?
#2

metacosm added a commit to quarkiverse/quarkus-operator-sdk that referenced this issue Jun 16, 2023
@metacosm
fix: revert to generating augmented RBACs by default
1fc0c2a 
When / if quarkusio/quarkus#34094 is
addressed, we should revisit this aspect of QOSDK. An alternative
solution would also be to extract the generation aspects of the
extension into its own module so that people could activate it on demand
via a maven profile, for example.
metacosm added a commit to quarkiverse/quarkus-operator-sdk that referenced this issue Jun 16, 2023
@metacosm
fix: remove build time namespaces property
a7eebc8 
When / if quarkusio/quarkus#34094 is
addressed, we should revisit this aspect of QOSDK. An alternative
solution would also be to extract the generation aspects of the
extension into its own module so that people could activate it on demand
via a maven profile, for example.
@metacosm metacosm mentioned this issue Jun 16, 2023
Merged
metacosm added a commit to quarkiverse/quarkus-operator-sdk that referenced this issue Jun 16, 2023
@metacosm
fix: remove build time namespaces property
66a4b4c 
When / if quarkusio/quarkus#34094 is
addressed, we should revisit this aspect of QOSDK. An alternative
solution would also be to extract the generation aspects of the
extension into its own module so that people could activate it on demand
via a maven profile, for example.
@Sgitario Sgitario mentioned this issue Jun 29, 2023
Closed
Sgitario added a commit to Sgitario/quarkus that referenced this issue Jun 29, 2023
@Sgitario
Allow disabling the manifests generation for K8s/OpenShift/Knative
0610282 
To me, it makes sense to separately enable/disable the generated resources by extension (kubernetes, knative, openshift, ...). We could disable the manifests generation for Kubernetes, but not for OpenShift for example. 

Fix quarkusio#34094
@Sgitario
Copy link
Contributor

  1. should kube resources be generated for quarkus dev?

DEV UI allows users to see the generated Kubernetes resources, so it's required.

  1. should there be option to turn on/off generation separate from enable/disable the extension

Originally, this was one of my suggestions. To me, it makes sense to separately enable/disable the generated resources by extension (kubernetes, knative, openshift, ...). We could disable the manifests generation for Kubernetes, but not for OpenShift for example.

For the second point, this is my proposed solution: #34416

Sgitario added a commit to Sgitario/quarkus that referenced this issue Jun 30, 2023
@Sgitario
Allow disabling the manifests generation for K8s/OpenShift/Knative
ccb141d 
To me, it makes sense to separately enable/disable the generated resources by extension (kubernetes, knative, openshift, ...). We could disable the manifests generation for Kubernetes, but not for OpenShift for example. 

Fix quarkusio#34094
Sgitario added a commit to Sgitario/quarkus that referenced this issue Jun 30, 2023
@Sgitario
Allow disabling the manifests generation for K8s/OpenShift/Knative
f58be1f 
To me, it makes sense to separately enable/disable the generated resources by extension (kubernetes, knative, openshift, ...). We could disable the manifests generation for Kubernetes, but not for OpenShift for example. 

Fix quarkusio#34094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kubernetes kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow disabling the manifests generation for K8s/OpenShift/Knative Sgitario/quarkus
3 participants
@maxandersen @metacosm @Sgitario