Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conditional dependencies for Flyway #41580

Closed
geoand opened this issue Jul 1, 2024 · 5 comments · Fixed by #41862
Closed

Use conditional dependencies for Flyway #41580

geoand opened this issue Jul 1, 2024 · 5 comments · Fixed by #41862
Labels
area/flyway good first issue Good for newcomers kind/enhancement New feature or request
Milestone
3.13.0.CR1

Comments

@geoand
Copy link
Contributor

geoand commented Jul 1, 2024

Description

We should be able to automatically pull in the necessary Flyway dependency when a supported SQL driver is used, by introducing a conditional dependency that will get triggered when the Flyway and the driver extensions are present

Implementation ideas

No response
@geoand geoand added the kind/enhancement New feature or request label Jul 1, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 1, 2024

/cc @cristhiank (flyway), @gastaldi (flyway), @gsmet (flyway)

@geoand geoand mentioned this issue Jul 1, 2024
Closed
geoand added a commit to geoand/quarkus that referenced this issue Jul 1, 2024
@geoand
Make flyway and jdbc-postgresql extensions work without other deps
ecb8767 
Relates to: quarkusio#41580
@geoand geoand mentioned this issue Jul 1, 2024
Merged
@geoand
Copy link
Contributor Author

geoand commented Jul 1, 2024

#41583 is for PostgreSQL.
Doing the same for other jdbc drivers is trivial by following the lead that of said PR.

geoand added a commit to geoand/quarkus that referenced this issue Jul 1, 2024
@geoand
Make flyway and jdbc-postgresql extensions work without other deps
4640895 
Relates to: quarkusio#41580
@geoand geoand added the good first issue Good for newcomers label Jul 1, 2024
@geoand
Copy link
Contributor Author

geoand commented Jul 1, 2024

I added the good first issue label because following the approach in #41583, doing the rest of the JDBC drivers should be straighforward.

@gastaldi
Copy link
Contributor

gastaldi commented Jul 1, 2024

Shall we create good first issues for the remaining JDBC drivers so it's easier to have them picked up?

geoand added a commit to geoand/quarkus that referenced this issue Jul 1, 2024
@geoand
Make flyway and jdbc-postgresql extensions work without other deps
3b93e65 
Relates to: quarkusio#41580
@geoand
Copy link
Contributor Author

geoand commented Jul 1, 2024

I added the label to original issue

geoand added a commit to geoand/quarkus that referenced this issue Jul 1, 2024
@geoand
Make flyway and jdbc-postgresql extensions work without other deps
ddf8453 
Relates to: quarkusio#41580
geoand added a commit that referenced this issue Jul 2, 2024
@geoand
Merge pull request #41583 from geoand/#41580
6d70b84 
Make flyway and jdbc-postgresql extensions work without any other required dependencies
This was referenced Jul 11, 2024
Closed
Merged
@gastaldi gastaldi linked a pull request Jul 12, 2024 that will close this issue
Make flyway and jdbc driver extensions work without any other required dependencies #41862
Merged
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 15, 2024
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Jul 31, 2024
@geoand @holly-cummins
Make flyway and jdbc-postgresql extensions work without other deps
f158eb3 
Relates to: quarkusio#41580
danielsoro pushed a commit to danielsoro/quarkus that referenced this issue Sep 20, 2024
@geoand @danielsoro
Make flyway and jdbc-postgresql extensions work without other deps
ebeae4a 
Relates to: quarkusio#41580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/flyway good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Milestone
3.13.0.CR1
2 participants
@gastaldi @geoand