VirtualThreadExtension does not take super classes into account #41782
Labels
Milestone
Comments
geoand
added
area/virtual-threads
|
/cc @cescoffier (virtual-threads), @ozangunalp (virtual-threads) |
|
Fancy a PR as you found the place where we need to check for the super class? |
|
Yes, of course. When I find the time I will create the PR |
This was referenced Jul 15, 2024
barreiro
pushed a commit
to barreiro/quarkus
that referenced
this issue
Jul 25, 2024
Fix for quarkusio#41782 Allow the usage of @ShouldPin and @ShouldNotPin on super classes
holly-cummins
pushed a commit
to holly-cummins/quarkus
that referenced
this issue
Jul 31, 2024
Fix for quarkusio#41782 Allow the usage of @ShouldPin and @ShouldNotPin on super classes
danielsoro
pushed a commit
to danielsoro/quarkus
that referenced
this issue
Sep 20, 2024
Fix for quarkusio#41782 Allow the usage of @ShouldPin and @ShouldNotPin on super classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
A lot of our test classes have a single super class which contains the
@ShouldNotPinannotation. The class VirtualThreadExtension does not take super classes into account when determing if recording is needed:https://github.com/quarkusio/quarkus/blob/main/independent-projects/junit5-virtual-threads/src/main/java/io/quarkus/test/junit5/virtual/internal/VirtualThreadExtension.java#L65
Expected behavior
When a super class declares the
@ShouldNotPinannotation that the extension validates that no pinning occurs.Actual behavior
The
@ShouldNotPinannotation is ignoredHow to Reproduce?
No response
Output of
uname -aorverNo response
Output of
java -versionNo response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --versionorgradlew --version)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: