-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
be explicit/use examples in websocket.next docs when it comes to subscribe call for action #42566
Comments
I think that in general users will not subscribe to the returned
I'm not sure either. CC @cescoffier |
We may need a warning containing the code showing how to subscribe but making it clear that the framework is usually subscribing. Explaining when it does subscribe and when it does not is tricky—it depends on the used extensions. |
Assigning it to me, I will update the documentation. |
…ubscribe to a Uni or Multi Fix quarkusio#42566
…ubscribe to a Uni or Multi Fix quarkusio#42566
Description
Trying to use websockets.next primiarly the client but i see similar challenges with server side.
reading https://quarkus.io/guides/websockets-next-reference there are a mix of places where it says things like:
"The method must subscribe to the
Multi
to receive these items (or return a Multi)."and
"Sends a text message to the client. It returns a
Uni
. It's non-blocking, but you must subscribe to it."..and no example so is this saying that i.e. it must be
.sendText(msg).subscribe()
or must it be.sendText(msg).subscribe().with(()->{});
? we should provide examples in these places to reduce ambiguity/errors.Implementation ideas
I would make a PR for these but I'm not actually sure what the required minimal samples are ;)
The text was updated successfully, but these errors were encountered: