-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS Regex Header Allow-Credentials Bug #43736
Comments
/cc @pedroigor (bearer-token) |
Any chance you could prepare a small Maven reproducer for the issue? You can attach it as a zip to your description or comment. Thanks! |
Sure. I have created the zip. I also attached some images with the curls. In the first image, the cors.origins is set to |
Thanks for the reproducer. From what I can see, it looks like an oversight. I'm working on a patch. |
We used to only consider exact matches which looks like an oversight. Fixes quarkusio#43736
Describe the bug
When using regex for CORS origins, it seems that when there is a match between the regex and the Origin, it seems that
Access-Control-Allow-Credentials
header is false, and according to the documentation it should be true. Am I missing something? This can be fixed by declaring the property, but I was just curious if it is a bug.Expected behavior
The header
Access-Control-Allow-Credentials
should be true when the regex matches the Origins.Actual behavior
If the property
quarkus.http.cors.access-control-allow-credentials
is not mentioned and if the regex matches the origin, the header's value is false.How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: