Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus fails to properly detect the patch part of internal versions of GraalVM CE builds #45873

Closed
zakkak opened this issue Jan 27, 2025 · 2 comments
Labels
area/native-image kind/bug Something isn't working

Comments

@zakkak
Copy link
Contributor

zakkak commented Jan 27, 2025

Describe the bug

In #36267 we introduced a work around for identifying the MAJOR.MINOR part of the internal versions of GraalVM CE builds. Unfortunately this work around sill fails to detect the patch version making conditions like the one in

@DisableIfBuiltWithGraalVMNewerThan(GraalVMVersion.GRAALVM_23_1_2)

to fail when using GraalVM CE builds.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Mandrel or GraalVM version (if different from Java)

GraalVM for JDK 21 CE built from https://github.com/graalvm/graalvm-community-jdk21u

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

In #34161 we discussed how we could improve the versions detection and concluded that it is not worth it given the internal and JDK versions will align with the 25 release.

As a result I suggest we remove any tests that are expected to fail due to this limitation.

@zakkak zakkak added area/native-image kind/bug Something isn't working labels Jan 27, 2025
Copy link

quarkus-bot bot commented Jan 27, 2025

/cc @Karm (native-image), @galderz (native-image)

@zakkak
Copy link
Contributor Author

zakkak commented Jan 28, 2025

Closing this as "not planned" following the same reasoning as in #34161, i.e., that it is not worth fixing it given the internal and JDK versions will align with the 25 release which will become available in September 2025.

@zakkak zakkak closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2025
carlesarnal pushed a commit to carlesarnal/quarkus that referenced this issue Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/native-image kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant