Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus Kubernetes Dekorate kubernetes.group partially applied #5135

Closed
emmanuelbernard opened this issue Nov 3, 2019 · 5 comments · Fixed by #5141
Closed

Quarkus Kubernetes Dekorate kubernetes.group partially applied #5135

emmanuelbernard opened this issue Nov 3, 2019 · 5 comments · Fixed by #5141
Labels
area/kubernetes kind/bug Something isn't working
Milestone

Comments

@emmanuelbernard
Copy link
Member

Create a new project
Add quarkus-kubernetes as dependency

Add the following to the application.properties file

kubernetes.group=example
quarkus.application.name=fruits-app

In target/kubernetes/kubernetes.yml, you will see

  • spec.template.spec.containers.image : ${username}/fruits-app:1.0-SNAPSHOT
  • metadata.labels.group: ${username}

Where ${username} is your environment username and where it should be example.

@iocanel @geoand

To decide if that's fixable by 0.28

@emmanuelbernard emmanuelbernard added kind/bug Something isn't working area/kubernetes labels Nov 3, 2019
@emmanuelbernard emmanuelbernard added this to the 0.28.0 milestone Nov 3, 2019
@geoand
Copy link
Contributor

geoand commented Nov 3, 2019

I'll check this out in an hour or so. @iocanel if you beat me to it, feel free to address

@geoand geoand changed the title Quarkus Kubernetes Dokorate kubernetes.group partially applied Quarkus Kubernetes Dekorate kubernetes.group partially applied Nov 3, 2019
@geoand
Copy link
Contributor

geoand commented Nov 3, 2019

I can reproduce the problem

@geoand
Copy link
Contributor

geoand commented Nov 3, 2019

So @iocanel there seem to be 2 problems:

  • setting kubernetes.group doesn't affect the group label of the created Service (although it does affect the group label of the Deployment).
  • setting kubernetes.group has no effect on the value of image of the container spec.
  • setting kubernetes.registry also doesn't seem to affect the value of image at all.

@geoand
Copy link
Contributor

geoand commented Nov 3, 2019

For the time being I'll see if I can work around these issues on the Quarkus side of things until they are properly addressed in Dekorate.

@geoand
Copy link
Contributor

geoand commented Nov 3, 2019

I think I have some hacks to get things working correctly. I'll add some tests and open a PR soon

geoand added a commit to geoand/quarkus that referenced this issue Nov 3, 2019
…ccount

This is just a quick fix around some dekorate issues. Once dekorate itself
properly handles these cases, the workaround (but not the test) should
be removed

Fix: quarkusio#5135
geoand added a commit to geoand/quarkus that referenced this issue Nov 3, 2019
…ccount

This is just a quick fix around some dekorate issues. Once dekorate itself
properly handles these cases, the workaround (but not the test) should
be removed

Fix: quarkusio#5135
geoand added a commit to geoand/quarkus that referenced this issue Nov 3, 2019
…ccount

This is just a quick fix around some dekorate issues. Once dekorate itself
properly handles these cases, the workaround (but not the test) should
be removed

Fix: quarkusio#5135
geoand added a commit that referenced this issue Nov 3, 2019
Ensure kubernetes.group and kubernetes.registry are used
aureamunoz pushed a commit to aureamunoz/quarkus that referenced this issue Nov 5, 2019
…ccount

This is just a quick fix around some dekorate issues. Once dekorate itself
properly handles these cases, the workaround (but not the test) should
be removed

Fix: quarkusio#5135
mmusgrov pushed a commit to mmusgrov/quarkus that referenced this issue Dec 13, 2019
…ccount

This is just a quick fix around some dekorate issues. Once dekorate itself
properly handles these cases, the workaround (but not the test) should
be removed

Fix: quarkusio#5135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants