Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the workaround for ForkJoin to spin up threads #5631

Closed
Sanne opened this issue Nov 20, 2019 · 7 comments
Closed

Remove the workaround for ForkJoin to spin up threads #5631

Sanne opened this issue Nov 20, 2019 · 7 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@Sanne
Copy link
Member

Sanne commented Nov 20, 2019

Describe the bug
We set -J-Djava.util.concurrent.ForkJoinPool.common.parallelism=1 in NativeImageBuildStep
to workaround for

It seems the GraalVM issue was resolved; are we safe to remove the workaround from Quarkus?

@stuartwdouglas needs your opinion at least

@Sanne Sanne added the kind/bug Something isn't working label Nov 20, 2019
@gsmet
Copy link
Member

gsmet commented Nov 20, 2019

I'm not sure the commit has been included in 19.2.x:
oracle/graal@e78fc21

From what I can see, it's only in 19.3 but I might be wrong.

@gwenneg
Copy link
Member

gwenneg commented Nov 20, 2019

This was included in 19.3.0 indeed.

@stuartwdouglas
Copy link
Member

This would be a good fix to have, I think it may speed up our native builds as I know the native compilation does use fork join internally in places.

@machi1990
Copy link
Member

This was included in 19.3.0 indeed.

@gwenneg Good to know. Any chance you could take this as part of your on going work with 19.3.0 ?

@gwenneg
Copy link
Member

gwenneg commented Nov 20, 2019

@machi1990 Sure, this could be part of #5358

@machi1990
Copy link
Member

Thanks @gwenneg

@gwenneg gwenneg self-assigned this Nov 20, 2019
@gwenneg
Copy link
Member

gwenneg commented Dec 5, 2019

Done in #5358.

@gwenneg gwenneg closed this as completed Dec 5, 2019
@gsmet gsmet added this to the 1.1.0 milestone Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants