Upgrade GraalVM to 19.3.0 #5358

gwenneg · 2019-11-10T08:28:03Z

This PR is related to #4218

It is incomplete and not meant to be merged for now. The build will most probably fail until the GraalVM 19.3.0 dependency is available and integrated into Quarkus.

geoand · 2019-11-10T09:27:17Z

How does this relate to #5353 ?

gwenneg · 2019-11-10T09:34:21Z

This PR could be considered as a follow-up of #5353.

gwenneg · 2019-11-20T21:33:56Z

I'm changing this PR a bit since GraalVM 19.3.0 was released today.

@cescoffier Could you please create the ubi-quarkus-native-image for 19.3.0?

~~I need to add CI jobs to run JDK 11 native tests before this PR can be promoted.~~ #5353 must also be merged before this one.

Edit: Actually, I'm not sure we need to wait for the JDK 11 native tests to merge this PR. I'll probably add them in a separate PR.

gsmet

Yeah, don't rush on adding the native image JDK 11 tests. I think we need to define our strategy regarding JDK 11 support and I would probably make it a separate PR once this one is in.

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java

bom/runtime/pom.xml

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java

gwenneg · 2019-11-21T08:04:00Z

PR promoted and ready to be reviewed/merged as soon as:

the artifacts are available on Maven Central
the ubi-quarkus-native-image is available for 19.3.0

cescoffier · 2019-11-21T14:12:17Z

Starting working on the docker image, I keep you posted.

gwenneg · 2019-11-22T22:15:16Z

Most native builds failed with an error I never saw before:

Status: Downloaded newer image for quay.io/quarkus/ubi-quarkus-native-image:19.3.0-java8
[INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] docker run -v /home/vsts/work/1/s/integration-tests/jpa-derby/target/quarkus-integration-test-jpa-derby-999-SNAPSHOT-native-image-source-jar:/project:z --user 1001:117 --rm quay.io/quarkus/ubi-quarkus-native-image:19.3.0-java8 -J-Dsun.nio.ch.maxUpdateArraySize=100 -J-Djava.util.logging.manager=org.jboss.logmanager.LogManager -J-DCoordinatorEnvironmentBean.transactionStatusManagerEnable=false -J-Dvertx.logger-delegate-factory-class-name=io.quarkus.vertx.core.runtime.VertxLogDelegateFactory -J-Dvertx.disableDnsResolver=true -J-Dio.netty.leakDetection.level=DISABLED -J-Dio.netty.allocator.maxOrder=1 --initialize-at-build-time= -H:InitialCollectionPolicy=com.oracle.svm.core.genscavenge.CollectionPolicy$BySpaceAndTime -jar quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner.jar -H:FallbackThreshold=0 -H:+ReportExceptionStackTraces -J-Xmx6g -H:-AddAllCharsets -H:EnableURLProtocols=http,https --enable-all-security-services -H:+JNI --no-server -H:-UseServiceLoaderFeature -H:+StackTrace quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]    classlist:  13,753.56 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]        (cap):   1,117.15 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]        setup:   3,138.49 ms
22:00:05,682 INFO  [org.hib.Version] HHH000412: Hibernate Core {5.4.9.Final}
22:00:05,736 INFO  [org.hib.ann.com.Version] HCANN000001: Hibernate Commons Annotations {5.1.0.Final}
22:00:05,811 INFO  [org.hib.dia.Dialect] HHH000400: Using dialect: org.hibernate.dialect.DerbyTenSevenDialect
22:00:09,234 INFO  [org.jbo.threads] JBoss Threads version 3.0.0.Final
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]   (typeflow):  67,807.49 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]    (objects):  27,713.14 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]   (features):   1,126.19 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]     analysis:  98,826.18 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]     (clinit):   1,270.38 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]     universe:   3,978.92 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]      (parse):  11,151.25 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]     (inline):  17,617.43 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]    (compile):  77,386.47 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]      compile: 109,618.66 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]        image:   4,547.37 ms
[quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner:20]        write:   1,401.82 ms
Fatal error: java.lang.RuntimeException: java.lang.RuntimeException: host C compiler or linker does not seem to work: java.lang.RuntimeException: returned 1

Running command: cc -v -o /project/quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner -z noexecstack -Wl,--gc-sections -Wl,--dynamic-list -Wl,/tmp/SVM-7977477395200125915/exported_symbols.list -Wl,-x -L/tmp/SVM-7977477395200125915 -L/opt/graalvm/jre/lib -L/opt/graalvm/jre/lib/svm/clibraries/linux-amd64 /tmp/SVM-7977477395200125915/quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner.o /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libffi.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/liblibchelper.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libjvm.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libstrictmath.a /opt/graalvm/jre/lib/libnet.a /opt/graalvm/jre/lib/libzip.a /opt/graalvm/jre/lib/libjava.a /opt/graalvm/jre/lib/libnio.a /opt/graalvm/jre/lib/libsunec.a /opt/graalvm/jre/lib/libsunec.a -lpthread -ldl -lpthread -lz -lm -lrt -lstdc++

Using built-in specs.
COLLECT_GCC=cc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/8/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-redhat-linux
Configured with: ../configure --enable-bootstrap --enable-languages=c,c++,fortran,lto --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared --enable-threads=posix --enable-checking=release --enable-multilib --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-gcc-major-version-only --with-linker-hash-style=gnu --enable-plugin --enable-initfini-array --with-isl --disable-libmpx --enable-offload-targets=nvptx-none --without-cuda-driver --enable-gnu-indirect-function --enable-cet --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux
Thread model: posix
gcc version 8.3.1 20190507 (Red Hat 8.3.1-4) (GCC) 
COMPILER_PATH=/usr/libexec/gcc/x86_64-redhat-linux/8/:/usr/libexec/gcc/x86_64-redhat-linux/8/:/usr/libexec/gcc/x86_64-redhat-linux/:/usr/lib/gcc/x86_64-redhat-linux/8/:/usr/lib/gcc/x86_64-redhat-linux/
LIBRARY_PATH=/usr/lib/gcc/x86_64-redhat-linux/8/:/usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/:/lib/../lib64/:/usr/lib/../lib64/:/usr/lib/gcc/x86_64-redhat-linux/8/../../../:/lib/:/usr/lib/
COLLECT_GCC_OPTIONS='-v' '-o' '/project/quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner' '-z' 'noexecstack' '-L/tmp/SVM-7977477395200125915' '-L/opt/graalvm/jre/lib' '-L/opt/graalvm/jre/lib/svm/clibraries/linux-amd64' '-mtune=generic' '-march=x86-64'
 /usr/libexec/gcc/x86_64-redhat-linux/8/collect2 -plugin /usr/libexec/gcc/x86_64-redhat-linux/8/liblto_plugin.so -plugin-opt=/usr/libexec/gcc/x86_64-redhat-linux/8/lto-wrapper -plugin-opt=-fresolution=/tmp/ccJ2IHwq.res -plugin-opt=-pass-through=-lgcc -plugin-opt=-pass-through=-lgcc_s -plugin-opt=-pass-through=-lc -plugin-opt=-pass-through=-lgcc -plugin-opt=-pass-through=-lgcc_s --build-id --no-add-needed --eh-frame-hdr --hash-style=gnu -m elf_x86_64 -dynamic-linker /lib64/ld-linux-x86-64.so.2 -o /project/quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner -z noexecstack /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crt1.o /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crti.o /usr/lib/gcc/x86_64-redhat-linux/8/crtbegin.o -L/tmp/SVM-7977477395200125915 -L/opt/graalvm/jre/lib -L/opt/graalvm/jre/lib/svm/clibraries/linux-amd64 -L/usr/lib/gcc/x86_64-redhat-linux/8 -L/usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64 -L/lib/../lib64 -L/usr/lib/../lib64 -L/usr/lib/gcc/x86_64-redhat-linux/8/../../.. --gc-sections --dynamic-list /tmp/SVM-7977477395200125915/exported_symbols.list -x /tmp/SVM-7977477395200125915/quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner.o /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libffi.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/liblibchelper.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libjvm.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libstrictmath.a /opt/graalvm/jre/lib/libnet.a /opt/graalvm/jre/lib/libzip.a /opt/graalvm/jre/lib/libjava.a /opt/graalvm/jre/lib/libnio.a /opt/graalvm/jre/lib/libsunec.a /opt/graalvm/jre/lib/libsunec.a -lpthread -ldl -lpthread -lz -lm -lrt -lstdc++ -lgcc --as-needed -lgcc_s --no-as-needed -lc -lgcc --as-needed -lgcc_s --no-as-needed /usr/lib/gcc/x86_64-redhat-linux/8/crtend.o /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crtn.o
/usr/bin/ld: cannot find -lstdc++
collect2: error: ld returned 1 exit status

	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:593)
	at java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:1005)
	at com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:462)
	at com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:315)
	at com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:454)
	at com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:115)
Caused by: java.lang.RuntimeException: host C compiler or linker does not seem to work: java.lang.RuntimeException: returned 1

Running command: cc -v -o /project/quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner -z noexecstack -Wl,--gc-sections -Wl,--dynamic-list -Wl,/tmp/SVM-7977477395200125915/exported_symbols.list -Wl,-x -L/tmp/SVM-7977477395200125915 -L/opt/graalvm/jre/lib -L/opt/graalvm/jre/lib/svm/clibraries/linux-amd64 /tmp/SVM-7977477395200125915/quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner.o /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libffi.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/liblibchelper.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libjvm.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libstrictmath.a /opt/graalvm/jre/lib/libnet.a /opt/graalvm/jre/lib/libzip.a /opt/graalvm/jre/lib/libjava.a /opt/graalvm/jre/lib/libnio.a /opt/graalvm/jre/lib/libsunec.a /opt/graalvm/jre/lib/libsunec.a -lpthread -ldl -lpthread -lz -lm -lrt -lstdc++

Using built-in specs.
COLLECT_GCC=cc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/8/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-redhat-linux
Configured with: ../configure --enable-bootstrap --enable-languages=c,c++,fortran,lto --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared --enable-threads=posix --enable-checking=release --enable-multilib --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-gcc-major-version-only --with-linker-hash-style=gnu --enable-plugin --enable-initfini-array --with-isl --disable-libmpx --enable-offload-targets=nvptx-none --without-cuda-driver --enable-gnu-indirect-function --enable-cet --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux
Thread model: posix
gcc version 8.3.1 20190507 (Red Hat 8.3.1-4) (GCC) 
COMPILER_PATH=/usr/libexec/gcc/x86_64-redhat-linux/8/:/usr/libexec/gcc/x86_64-redhat-linux/8/:/usr/libexec/gcc/x86_64-redhat-linux/:/usr/lib/gcc/x86_64-redhat-linux/8/:/usr/lib/gcc/x86_64-redhat-linux/
LIBRARY_PATH=/usr/lib/gcc/x86_64-redhat-linux/8/:/usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/:/lib/../lib64/:/usr/lib/../lib64/:/usr/lib/gcc/x86_64-redhat-linux/8/../../../:/lib/:/usr/lib/
COLLECT_GCC_OPTIONS='-v' '-o' '/project/quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner' '-z' 'noexecstack' '-L/tmp/SVM-7977477395200125915' '-L/opt/graalvm/jre/lib' '-L/opt/graalvm/jre/lib/svm/clibraries/linux-amd64' '-mtune=generic' '-march=x86-64'
 /usr/libexec/gcc/x86_64-redhat-linux/8/collect2 -plugin /usr/libexec/gcc/x86_64-redhat-linux/8/liblto_plugin.so -plugin-opt=/usr/libexec/gcc/x86_64-redhat-linux/8/lto-wrapper -plugin-opt=-fresolution=/tmp/ccJ2IHwq.res -plugin-opt=-pass-through=-lgcc -plugin-opt=-pass-through=-lgcc_s -plugin-opt=-pass-through=-lc -plugin-opt=-pass-through=-lgcc -plugin-opt=-pass-through=-lgcc_s --build-id --no-add-needed --eh-frame-hdr --hash-style=gnu -m elf_x86_64 -dynamic-linker /lib64/ld-linux-x86-64.so.2 -o /project/quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner -z noexecstack /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crt1.o /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crti.o /usr/lib/gcc/x86_64-redhat-linux/8/crtbegin.o -L/tmp/SVM-7977477395200125915 -L/opt/graalvm/jre/lib -L/opt/graalvm/jre/lib/svm/clibraries/linux-amd64 -L/usr/lib/gcc/x86_64-redhat-linux/8 -L/usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64 -L/lib/../lib64 -L/usr/lib/../lib64 -L/usr/lib/gcc/x86_64-redhat-linux/8/../../.. --gc-sections --dynamic-list /tmp/SVM-7977477395200125915/exported_symbols.list -x /tmp/SVM-7977477395200125915/quarkus-integration-test-jpa-derby-999-SNAPSHOT-runner.o /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libffi.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/liblibchelper.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libjvm.a /opt/graalvm/jre/lib/svm/clibraries/linux-amd64/libstrictmath.a /opt/graalvm/jre/lib/libnet.a /opt/graalvm/jre/lib/libzip.a /opt/graalvm/jre/lib/libjava.a /opt/graalvm/jre/lib/libnio.a /opt/graalvm/jre/lib/libsunec.a /opt/graalvm/jre/lib/libsunec.a -lpthread -ldl -lpthread -lz -lm -lrt -lstdc++ -lgcc --as-needed -lgcc_s --no-as-needed -lc -lgcc --as-needed -lgcc_s --no-as-needed /usr/lib/gcc/x86_64-redhat-linux/8/crtend.o /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crtn.o
/usr/bin/ld: cannot find -lstdc++
collect2: error: ld returned 1 exit status

	at com.oracle.svm.hosted.image.NativeBootImageViaCC.write(NativeBootImageViaCC.java:382)
	at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:652)
	at com.oracle.svm.hosted.NativeImageGenerator.lambda$run$0(NativeImageGenerator.java:445)
	at java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1386)
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)
Error: Image build request failed with exit status 1

stuartwdouglas · 2019-12-04T00:24:18Z

I needed to remove some of the substitutions to get the keycloak tests working. Basically what was happening is that static init methods were registering providers, that were then causing problems for native image. I just moved all this to runtime, which seems to have fixed it (at least in my local testing).

BTW @gwenneg I noticed that you mentioned you needed to recompile graal to figure out what was causing the problem. Not sure if you are aware of this but if you build with '-Dquarkus.native.debug-build-process=true' then you can just attach a debugger and set a breakpoint to see what is going on without needing a custom graal build. I figured this issue out with a breakpoint at java.security.Security#insertProviderAt to see where the providers were being registered.

gwenneg · 2019-12-04T00:27:16Z

Does that work with the community edition of GraalVM? I thought the enterprise edition was needed for debugging. I'm still new to GraalVM so there are probably many things (like this one) I don't know yet :) Thanks for the tip!

stuartwdouglas · 2019-12-04T00:29:00Z

Yea, native-image is just a standard java program (as in the actual build process), you can just attach a debugger as normal and debug the build process itself. This does not let you actually debug the resulting program though.

core/deployment/src/main/java/io/quarkus/deployment/ThreadLocalRandomProcessor.java

gwenneg · 2019-12-04T06:14:53Z

The Quarkus doc needs to be updated, I'll do it today.

gwenneg · 2019-12-04T06:47:52Z

Thanks @stuartwdouglas for your help with the NPE issue!

Remove some problematic substitutions and make bouncycastle classes initialized at runtime to work around security provider bug

docs/src/main/asciidoc/native-and-ssl.adoc

gsmet

Awesome team work, thanks.

I think we need some documentation work:

document how to use GraalVM JDK 11 tech preview if possible, either with Docker or standard install
see if the SSL documentation needs some updates. From my understanding, it might not be needed anymore to include the SunEC library. We need to properly check that.

@gwenneg do you think you will have the time to do it soon?

core/deployment/src/main/java/io/quarkus/deployment/ThreadLocalRandomProcessor.java

gsmet · 2019-12-04T15:16:13Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java

@@ -132,7 +132,7 @@
    /**
     * The docker image to use to do the image build
     */
-    @ConfigItem(defaultValue = "quay.io/quarkus/ubi-quarkus-native-image:19.2.1")
+    @ConfigItem(defaultValue = "quay.io/quarkus/ubi-quarkus-native-image:19.3.0-java8")


If we plan to support JDK 11, we need to document how to do it.

And we should at least try to run the tests manually once to check it's OK.

gsmet · 2019-12-04T15:24:33Z

@gwenneg I let you the honor to push the Merge button, considering how much effort you put into that one. Have fun :).

gwenneg · 2019-12-04T19:02:46Z

I'm running tests with both JDK to check everything's OK now. Please don't merge this PR until I'm done. Edit: @gsmet: Your comment wasn't visible when I wrote mine, yes I'll push the button :)

gwenneg · 2019-12-05T00:33:42Z

The JDK 11 native tests are still running locally, I'll merge the PR tomorrow morning once I've checked the results.

I'll also take care of the documentation tomorrow night with a dedicated PR.

bobmcwhirter · 2019-12-05T00:47:51Z

You rock, my friend!

…

On Wed, Dec 4, 2019 at 7:33 PM Gwenneg Lepage ***@***.***> wrote: The JDK 11 native tests are still running locally, I'll merge the PR tomorrow morning once I've checked the results. I'll also take care of the documentation tomorrow night with a dedicated PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5358?email_source=notifications&email_token=AAAD4T7AUPY2YJMEUJKMASTQXBD6NA5CNFSM4JLLNSU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7BJ6Y#issuecomment-561911035>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAD4TYV3ARF557EKG22LT3QXBD6NANCNFSM4JLLNSUQ> .

gwenneg · 2019-12-05T05:59:30Z

Comment removed, wrong tests conditions.

gwenneg · 2019-12-05T09:18:20Z

I'm merging this PR as it feels we're ready for GraalVM 19.3.0 with JDK 8.

There are still some issues I need to investigate with JDK 11 though, I will continue this work from #5682.

Thanks a lot everyone for your help with this PR!

stuartwdouglas · 2019-12-05T10:05:08Z

Thanks for your awesome work on this @gwenneg!

geoand · 2019-12-05T10:54:41Z

Great stuff @gwenneg !!!

machi1990 · 2019-12-05T11:37:07Z

Awesome work @gwenneg!!

gwenneg added the coding-in-progress label Nov 10, 2019

gwenneg mentioned this pull request Nov 10, 2019

Lazily recompute Inet4Address, Inet6Address and CidrAddress fields at runtime #5353

Merged

cescoffier removed the coding-in-progress label Nov 13, 2019

gwenneg changed the title ~~Upgrade GraalVM to 19.3.0~~ Replace com.oracle.svm.core.jdk.LocalizationSupport with LocalizationFeature Nov 14, 2019

gwenneg added the env/graalvm-java11 Relating to using GraalVM native image generation on Java 11 label Nov 14, 2019

gwenneg force-pushed the issue-4218-upgrade-graalvm-to-19.3.0 branch from ce0f04a to b7435ba Compare November 20, 2019 21:27

gwenneg changed the title ~~Replace com.oracle.svm.core.jdk.LocalizationSupport with LocalizationFeature~~ Upgrade GraalVM to 19.3.0 Nov 20, 2019

gwenneg mentioned this pull request Nov 20, 2019

Remove the workaround for ForkJoin to spin up threads #5631

Closed

gwenneg force-pushed the issue-4218-upgrade-graalvm-to-19.3.0 branch from b7435ba to 1fcbd22 Compare November 20, 2019 22:52

gsmet requested changes Nov 20, 2019

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java Outdated Show resolved Hide resolved

bom/runtime/pom.xml Show resolved Hide resolved

gwenneg commented Nov 20, 2019

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java Show resolved Hide resolved

gwenneg force-pushed the issue-4218-upgrade-graalvm-to-19.3.0 branch 2 times, most recently from 506a6a0 to 487ba9d Compare November 20, 2019 23:07

gwenneg marked this pull request as ready for review November 21, 2019 06:47

gwenneg force-pushed the issue-4218-upgrade-graalvm-to-19.3.0 branch 2 times, most recently from 81ef322 to 5d6b945 Compare November 21, 2019 08:00

gwenneg added the release/noteworthy-feature label Nov 21, 2019

gwenneg added this to the 1.1.0 milestone Nov 21, 2019

gwenneg mentioned this pull request Nov 21, 2019

Upgrade to GraalVM 19.3.0 / Java 8 edition #4218

Closed

jaikiran mentioned this pull request Nov 22, 2019

Fix resource registration in native-image for 19.3 of Graal #5676

Closed

gwenneg force-pushed the issue-4218-upgrade-graalvm-to-19.3.0 branch from 5d6b945 to 80b1b9f Compare November 22, 2019 17:32

gwenneg removed the env/graalvm-java11 Relating to using GraalVM native image generation on Java 11 label Nov 22, 2019

gwenneg force-pushed the issue-4218-upgrade-graalvm-to-19.3.0 branch 2 times, most recently from 397db6b to eaffb98 Compare November 22, 2019 21:11

Initialize GpgSigner at runtime to avoid security provider problem

344e6fe

stuartwdouglas requested a review from gsmet December 4, 2019 02:20

stuartwdouglas force-pushed the issue-4218-upgrade-graalvm-to-19.3.0 branch from 93a4422 to 763797a Compare December 4, 2019 02:22

gwenneg commented Dec 4, 2019

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/ThreadLocalRandomProcessor.java Show resolved Hide resolved

Make Keycloak work on Graal 19.3.0

85d8746

Remove some problematic substitutions and make bouncycastle classes initialized at runtime to work around security provider bug

gwenneg commented Dec 4, 2019

View reviewed changes

docs/src/main/asciidoc/native-and-ssl.adoc Show resolved Hide resolved

gwenneg force-pushed the issue-4218-upgrade-graalvm-to-19.3.0 branch from 763797a to 85d8746 Compare December 4, 2019 07:07

gsmet approved these changes Dec 4, 2019

View reviewed changes

gwenneg merged commit 0be78a6 into quarkusio:master Dec 5, 2019

gwenneg deleted the issue-4218-upgrade-graalvm-to-19.3.0 branch December 5, 2019 09:31

gsmet added the release/breaking-change label Dec 11, 2019

gsmet modified the milestones: 1.1.0.CR1, 1.2.0 Dec 23, 2019

gwenneg mentioned this pull request Jan 16, 2020

Support both GraalVM 19.2.1 and 19.3.1 #6574

Merged

gsmet removed release/breaking-change release/noteworthy-feature labels Jan 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade GraalVM to 19.3.0 #5358

Upgrade GraalVM to 19.3.0 #5358

gwenneg commented Nov 10, 2019 •

edited

Loading

geoand commented Nov 10, 2019

gwenneg commented Nov 10, 2019

gwenneg commented Nov 20, 2019 •

edited

Loading

gsmet left a comment

gwenneg commented Nov 21, 2019 •

edited

Loading

cescoffier commented Nov 21, 2019

gwenneg commented Nov 22, 2019 •

edited

Loading

stuartwdouglas commented Dec 4, 2019

gwenneg commented Dec 4, 2019 •

edited

Loading

stuartwdouglas commented Dec 4, 2019

gwenneg commented Dec 4, 2019

gwenneg commented Dec 4, 2019

gsmet left a comment

gsmet Dec 4, 2019

gsmet commented Dec 4, 2019

gwenneg commented Dec 4, 2019 •

edited

Loading

gwenneg commented Dec 5, 2019

bobmcwhirter commented Dec 5, 2019 via email

gwenneg commented Dec 5, 2019 •

edited

Loading

gwenneg commented Dec 5, 2019 •

edited

Loading

stuartwdouglas commented Dec 5, 2019

geoand commented Dec 5, 2019 •

edited

Loading

machi1990 commented Dec 5, 2019

Upgrade GraalVM to 19.3.0 #5358

Upgrade GraalVM to 19.3.0 #5358

Conversation

gwenneg commented Nov 10, 2019 • edited Loading

geoand commented Nov 10, 2019

gwenneg commented Nov 10, 2019

gwenneg commented Nov 20, 2019 • edited Loading

gsmet left a comment

Choose a reason for hiding this comment

gwenneg commented Nov 21, 2019 • edited Loading

cescoffier commented Nov 21, 2019

gwenneg commented Nov 22, 2019 • edited Loading

stuartwdouglas commented Dec 4, 2019

gwenneg commented Dec 4, 2019 • edited Loading

stuartwdouglas commented Dec 4, 2019

gwenneg commented Dec 4, 2019

gwenneg commented Dec 4, 2019

gsmet left a comment

Choose a reason for hiding this comment

gsmet Dec 4, 2019

Choose a reason for hiding this comment

gsmet commented Dec 4, 2019

gwenneg commented Dec 4, 2019 • edited Loading

gwenneg commented Dec 5, 2019

bobmcwhirter commented Dec 5, 2019 via email

gwenneg commented Dec 5, 2019 • edited Loading

gwenneg commented Dec 5, 2019 • edited Loading

stuartwdouglas commented Dec 5, 2019

geoand commented Dec 5, 2019 • edited Loading

machi1990 commented Dec 5, 2019

gwenneg commented Nov 10, 2019 •

edited

Loading

gwenneg commented Nov 20, 2019 •

edited

Loading

gwenneg commented Nov 21, 2019 •

edited

Loading

gwenneg commented Nov 22, 2019 •

edited

Loading

gwenneg commented Dec 4, 2019 •

edited

Loading

gwenneg commented Dec 4, 2019 •

edited

Loading

gwenneg commented Dec 5, 2019 •

edited

Loading

gwenneg commented Dec 5, 2019 •

edited

Loading

geoand commented Dec 5, 2019 •

edited

Loading