Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource registration in native-image for 19.3 of Graal #5676

Closed
wants to merge 1 commit into from
Closed

Fix resource registration in native-image for 19.3 of Graal #5676

wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

Building a native-image of some random Quarkus application, with latest Quarkus master and Graal 19.3.0 shows this following exception:

java.lang.NoSuchMethodException: com.oracle.svm.core.jdk.LocalizationSupport.addBundleToCache(java.lang.String)
	at java.lang.Class.getDeclaredMethod(Class.java:2130)
	at io.quarkus.runner.AutoFeature.beforeAnalysis(AutoFeature.zig:920)
	at com.oracle.svm.hosted.NativeImageGenerator.lambda$runPointsToAnalysis$7(NativeImageGenerator.java:669)
	at com.oracle.svm.hosted.FeatureHandler.forEachFeature(FeatureHandler.java:63)
	at com.oracle.svm.hosted.NativeImageGenerator.runPointsToAnalysis(NativeImageGenerator.java:669)
	at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:530)
	at com.oracle.svm.hosted.NativeImageGenerator.lambda$run$0(NativeImageGenerator.java:445)
	at java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1386)
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

The build doesn't fail, but clearly this means the resources aren't registered.

The commit here fixes the issue by changing our references of com.oracle.svm.core.jdk.LocalizationSupport to com.oracle.svm.core.jdk.LocalizationFeature to match the Graal 19.3.0 renaming of this class.

This commit is only relevant to the master branch.

@jaikiran jaikiran requested a review from gwenneg November 22, 2019 04:51
@jaikiran
Copy link
Member Author

jaikiran commented Nov 22, 2019

Actually, PR #5358 which relates to Graal 19.3.0 upgrade is still open. I misunderstood the merging of this #5353 PR to imply that the other one has already been merged too.

My PR isn't doing anything different than what #5358 already does. So closing this.

@jaikiran jaikiran closed this Nov 22, 2019
@gsmet gsmet added this to the 1.1.0 milestone Nov 24, 2019
@jaikiran jaikiran deleted the localizationsupport-rename branch July 4, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants