-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to GraalVM 19.3.0 / Java 8 edition #4218
Comments
This release should also add support for Java 11 on GraalVM. |
Yeah or drop Java 8 and only test Java 11. /cc @dmlloyd |
As a lot of people still use Java 8 it depends if you are ready to take the risk ! |
Hopefully people aren't using Java 8 for new projects :) |
You will be very surprised ... or disapointed :) |
Reopening, we haven't upgraded yet. |
/cc @cescoffier @dmlloyd please have a look at the added elements in the description. @cescoffier especially the Netty upgrade part for you. |
Additional patch required for GraalVM 19.3.0:
The The |
@gsmet the |
@gsmet Yes, I'll take care of it. |
@cescoffier Does it seem reasonnable to upgrade netty to |
I just submitted a PR that should make the netty upgrade optional by introducing the GraalVM |
@gsmet Can I safely create a PR that would introduce the JDK 11 native build in the CI? I don't want to disturb the CI because of additional artifacts or jobs right before the |
@gwenneg let's wait a bit. CI is sufficiently unstable right now. Let's do that mid next week. |
@cstancu btw, I wanted to apologize for us not having been very reactive on that one. We were all busy preparing 1.0. As you can see, it's in good hands now and we are making good progress. Thanks for raising all these issues and your advice on how to fix them! |
FYI it seems that graalvm 19.3.0 is available now. |
FYI the version road map for GraalVM is here https://www.graalvm.org/docs/release-notes/version-roadmap/ |
Thanks for the info @jabby! |
Cool, opened #5682 then. |
I've tested it with:
and there's still other issues:
That's by building the first integration test building native images: I did rebase this PR on master, not sure if that changes things. |
I saw that one during a test with GraalVM |
From https://www.graalvm.org/docs/release-notes/19_3/ :
I suppose the @Sanne Does it seem OK to you to deprecate |
That seems odd to have to require JNI support for all extensions - it certainly doesn't come for free? I hope someone could at least investigate why we'd need that. @bobmcwhirter might have some clues? |
Question asked in the GraalVM native-image Slack channel. |
I've finally made progress on the docker images. It required duplicating all our images to support both java8 and java11. They are getting built by the CI right now (but due to the number of images, it is taking lot of time). Hopefully tonight we will get them. So, the images are slightly different in the sense their versions explicitly say |
JNI is required for GraalVM 19.3.0. We'll want to change the
Indeed. But we've been looking into it. |
thanks @cescoffier - I assume the weird naming is temporary as it seems we'll want to switch to java11 as exclusive choice as soon as we consider it "mature enough"? I'd suggest to not go overboard with solutions to handle multiple lines of docker images. We'll probably consider |
it's been a ride... but here it is: So the full name of the image is: quay.io/quarkus/ubi-quarkus-native-image:19.3.0-java8 |
Thanks @cescoffier! I'll run the Quarkus CI with GraalVM |
Yes, we can revert to single image whenever we want.
Yes, but for testing, we need both images :-) |
Using GraalVM
I followed the instruction for getting started here using |
Hi @breandan! Quarkus currently supports GraalVM We are working on the integration of GraalVM So for now, please use GraalVM |
I think so. |
I created this issue to gather notes about the next GraalVM upgrade.
Per Codrut Stancu from the GraalVM team on Zulip:
Per Codrut again
Note that this means an upgrade of Netty to
4.1.43.Final
. Or another option is to port this patch https://github.com/netty/netty/pull/9631/files to Quarkus via usage of our reflection registration API but I'm not sure if we haveallowUnsafeAccess
support right now.The text was updated successfully, but these errors were encountered: