-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Infinispan to 11.0.1.Final #10989
Conversation
af9ac39
to
8e467d6
Compare
Doesn't look good:
Did you run the tests locally before pushing a PR? You can quickly deploy things with |
@gsmet not really. I will was expecting them to work and my machine has been behaving very slow today |
I dunno, you haven't changed the compiler plugin version and I think we are still using a JBoss-specific version of 3.8.0 for the build. |
locally, I get the 3.8.1 pom instead of 3.8.0 |
65d7779
to
8e467d6
Compare
@anistor I need you help here to understand please |
8e467d6
to
e988b06
Compare
I have a vague recollection of @stuartwdouglas manually adding the annotation processors in the pom as we had an issue but I can't find it again. @stuartwdouglas does it ring a bell? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be careful with this PR, CI wasn't triggered for the latest commit so it appears green. Check that we have 30+ checks before merging.
301d94d
to
eae3e5b
Compare
Still failing with:
Could you test locally before pushing to CI? There's no point in using our scarce CI resources when a small local build could at least fix the most obvious errors. Thanks! |
Just to be extra clear: we don't expect you to do a full run locally. But you should at least run the tests of the affected modules. |
eae3e5b
to
642c86a
Compare
yes sorry @gsmet I was like a happy flower confident without paying enough attention to the process. I managed to have the native test passing locally and I corrected a couple of additional things
|
Perfect, thanks, merging! |
</dependency> | ||
<dependency> | ||
<groupId>com.fasterxml.jackson.core</groupId> | ||
<artifactId>jackson-annotations</artifactId> | ||
<version>2.10.0</version> | ||
<version>2.11.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for another day but I don't think you need the versions here anymore. I think we used to have them because of a version conflict but it should be all good now.
Somehow there was an issue upgrading the pom.xml and the dependency was not upgraded in my latests PR, even if genuinely I thought it was correctly done