Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Infinispan to 11.0.1.Final #10989

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

karesti
Copy link
Member

@karesti karesti commented Jul 27, 2020

Somehow there was an issue upgrading the pom.xml and the dependency was not upgraded in my latests PR, even if genuinely I thought it was correctly done

@boring-cyborg boring-cyborg bot added the area/dependencies Pull requests that update a dependency file label Jul 27, 2020
@karesti karesti force-pushed the upgrade-infinispan-version branch from af9ac39 to 8e467d6 Compare July 27, 2020 14:11
@boring-cyborg boring-cyborg bot added the area/infinispan Infinispan label Jul 27, 2020
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 27, 2020
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 27, 2020
@gsmet
Copy link
Member

gsmet commented Jul 27, 2020

Doesn't look good:

2020-07-27T16:13:56.3488679Z [ERROR] io.quarkus.it.infinispan.client.InfinispanClientFunctionalityTest.testNearCacheInvalidation  Time elapsed: 0.021 s  <<< ERROR!
2020-07-27T16:13:56.3493510Z java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
2020-07-27T16:13:56.3499841Z 	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:470)
2020-07-27T16:13:56.3505653Z 	at io.quarkus.test.junit.QuarkusTestExtension.beforeEach(QuarkusTestExtension.java:352)
2020-07-27T16:13:56.3513751Z 	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:161)
2020-07-27T16:13:56.3522837Z 	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacksUntilExceptionOccurs$5(TestMethodTestDescriptor.java:197)
2020-07-27T16:13:56.3529134Z 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
2020-07-27T16:13:56.3539354Z 	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeMethodsOrCallbacksUntilExceptionOccurs(TestMethodTestDescriptor.java:197)
2020-07-27T16:13:56.3560692Z 	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeEachCallbacks(TestMethodTestDescriptor.java:160)
2020-07-27T16:13:56.3577031Z 	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:131)
2020-07-27T16:13:56.3583329Z 	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:71)
2020-07-27T16:13:56.3599605Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
2020-07-27T16:13:56.3608037Z 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
2020-07-27T16:13:56.3618055Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
2020-07-27T16:13:56.3624170Z 	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
2020-07-27T16:13:56.3631976Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
2020-07-27T16:13:56.3638525Z 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
2020-07-27T16:13:56.3644627Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
2020-07-27T16:13:56.3652732Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
2020-07-27T16:13:56.3658751Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
2020-07-27T16:13:56.3668530Z 	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
2020-07-27T16:13:56.3675233Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
2020-07-27T16:13:56.3681930Z 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
2020-07-27T16:13:56.3688625Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
2020-07-27T16:13:56.3693563Z 	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
2020-07-27T16:13:56.3700036Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
2020-07-27T16:13:56.3706332Z 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
2020-07-27T16:13:56.3712810Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
2020-07-27T16:13:56.3721668Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
2020-07-27T16:13:56.3726840Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
2020-07-27T16:13:56.3736129Z 	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
2020-07-27T16:13:56.3743659Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
2020-07-27T16:13:56.3750038Z 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
2020-07-27T16:13:56.3756815Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
2020-07-27T16:13:56.3762294Z 	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
2020-07-27T16:13:56.3768814Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
2020-07-27T16:13:56.3774887Z 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
2020-07-27T16:13:56.3782868Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
2020-07-27T16:13:56.3788661Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
2020-07-27T16:13:56.3797339Z 	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
2020-07-27T16:13:56.3804135Z 	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
2020-07-27T16:13:56.3810582Z 	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
2020-07-27T16:13:56.3815731Z 	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:248)
2020-07-27T16:13:56.3821575Z 	at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$5(DefaultLauncher.java:211)
2020-07-27T16:13:56.3827474Z 	at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:226)
2020-07-27T16:13:56.3830419Z 	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:199)
2020-07-27T16:13:56.3832268Z 	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:132)
2020-07-27T16:13:56.3838652Z 	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:188)
2020-07-27T16:13:56.3845054Z 	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:154)
2020-07-27T16:13:56.3852382Z 	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:128)
2020-07-27T16:13:56.3857825Z 	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
2020-07-27T16:13:56.3863043Z 	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
2020-07-27T16:13:56.3867738Z 	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
2020-07-27T16:13:56.3874817Z 	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)
2020-07-27T16:13:56.3881715Z Caused by: java.lang.RuntimeException: Failed to start quarkus
2020-07-27T16:13:56.3886361Z 	at io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:615)
2020-07-27T16:13:56.3890454Z 	at io.quarkus.runtime.Application.start(Application.java:90)
2020-07-27T16:13:56.3912045Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2020-07-27T16:13:56.3913128Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2020-07-27T16:13:56.3914095Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2020-07-27T16:13:56.3914989Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2020-07-27T16:13:56.3916011Z 	at io.quarkus.runner.bootstrap.StartupActionImpl.run(StartupActionImpl.java:223)
2020-07-27T16:13:56.3916926Z 	at io.quarkus.test.junit.QuarkusTestExtension.doJavaStart(QuarkusTestExtension.java:209)
2020-07-27T16:13:56.3917823Z 	at io.quarkus.test.junit.QuarkusTestExtension.ensureStarted(QuarkusTestExtension.java:448)
2020-07-27T16:13:56.3919908Z 	at io.quarkus.test.junit.QuarkusTestExtension.beforeAll(QuarkusTestExtension.java:481)
2020-07-27T16:13:56.3920847Z 	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$7(ClassBasedTestDescriptor.java:359)
2020-07-27T16:13:56.3922034Z 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
2020-07-27T16:13:56.3922973Z 	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeBeforeAllCallbacks(ClassBasedTestDescriptor.java:359)
2020-07-27T16:13:56.3923877Z 	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:189)
2020-07-27T16:13:56.3924770Z 	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:78)
2020-07-27T16:13:56.3925664Z 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:132)
2020-07-27T16:13:56.3926540Z 	... 32 more
2020-07-27T16:13:56.3927457Z Caused by: org.infinispan.client.hotrod.exceptions.HotRodClientException:Request for messageId=15 returned server error (status=0x85): org.infinispan.commons.marshall.MarshallingException: No marshaller registered for Protobuf type book_sample.Book
2020-07-27T16:13:56.3928388Z 	at org.infinispan.client.hotrod.impl.protocol.Codec20.checkForErrorsInResponseStatus(Codec20.java:329)
2020-07-27T16:13:56.3932519Z 	at org.infinispan.client.hotrod.impl.protocol.Codec20.readHeader(Codec20.java:168)
2020-07-27T16:13:56.3939391Z 	at org.infinispan.client.hotrod.impl.transport.netty.HeaderDecoder.decode(HeaderDecoder.java:140)
2020-07-27T16:13:56.3946779Z 	at org.infinispan.client.hotrod.impl.transport.netty.HintedReplayingDecoder.callDecode(HintedReplayingDecoder.java:94)
2020-07-27T16:13:56.3952876Z 	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
2020-07-27T16:13:56.3959671Z 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
2020-07-27T16:13:56.3966087Z 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
2020-07-27T16:13:56.3972355Z 	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
2020-07-27T16:13:56.3977528Z 	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286)
2020-07-27T16:13:56.3984414Z 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
2020-07-27T16:13:56.3991285Z 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
2020-07-27T16:13:56.3999175Z 	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
2020-07-27T16:13:56.4004236Z 	at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1518)
2020-07-27T16:13:56.4009104Z 	at io.netty.handler.ssl.SslHandler.decodeJdkCompatible(SslHandler.java:1267)
2020-07-27T16:13:56.4013175Z 	at io.netty.handler.ssl.SslHandler.decode(SslHandler.java:1314)
2020-07-27T16:13:56.4019854Z 	at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:501)
2020-07-27T16:13:56.4025162Z 	at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:440)
2020-07-27T16:13:56.4031464Z 	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
2020-07-27T16:13:56.4040724Z 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
2020-07-27T16:13:56.4047139Z 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
2020-07-27T16:13:56.4053383Z 	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
2020-07-27T16:13:56.4059389Z 	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
2020-07-27T16:13:56.4065730Z 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
2020-07-27T16:13:56.4072103Z 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
2020-07-27T16:13:56.4078912Z 	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
2020-07-27T16:13:56.4085965Z 	at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:792)
2020-07-27T16:13:56.4092398Z 	at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:475)
2020-07-27T16:13:56.4098343Z 	at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)
2020-07-27T16:13:56.4104250Z 	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
2020-07-27T16:13:56.4109052Z 	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
2020-07-27T16:13:56.4114656Z 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
2020-07-27T16:13:56.4121130Z 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
2020-07-27T16:13:56.4124714Z 	at java.base/java.lang.Thread.run(Thread.java:834)

Did you run the tests locally before pushing a PR? You can quickly deploy things with mvn clean install -Dquickly and the run your specific IT.

@karesti
Copy link
Member Author

karesti commented Jul 27, 2020

@gsmet not really. I will was expecting them to work and my machine has been behaving very slow today

@karesti
Copy link
Member Author

karesti commented Jul 27, 2020

@gsmet could this be related to #9980 ?

@gsmet
Copy link
Member

gsmet commented Jul 27, 2020

I dunno, you haven't changed the compiler plugin version and I think we are still using a JBoss-specific version of 3.8.0 for the build.

@karesti
Copy link
Member Author

karesti commented Jul 27, 2020

I dunno, you haven't changed the compiler plugin version and I think we are still using a JBoss-specific version of 3.8.0 for the build.

locally, I get the 3.8.1 pom instead of 3.8.0

@karesti karesti force-pushed the upgrade-infinispan-version branch from 65d7779 to 8e467d6 Compare July 27, 2020 20:08
@karesti
Copy link
Member Author

karesti commented Jul 27, 2020

@anistor I need you help here to understand please

@karesti karesti force-pushed the upgrade-infinispan-version branch from 8e467d6 to e988b06 Compare July 27, 2020 21:09
@gsmet
Copy link
Member

gsmet commented Jul 28, 2020

I have a vague recollection of @stuartwdouglas manually adding the annotation processors in the pom as we had an issue but I can't find it again. @stuartwdouglas does it ring a bell?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with this PR, CI wasn't triggered for the latest commit so it appears green. Check that we have 30+ checks before merging.

@karesti karesti force-pushed the upgrade-infinispan-version branch 2 times, most recently from 301d94d to eae3e5b Compare July 28, 2020 14:58
@gsmet
Copy link
Member

gsmet commented Jul 28, 2020

Still failing with:

2020-07-28T15:55:18.6192920Z Error: could not find target method: private void io.quarkus.infinispan.client.runtime.graal.SubstituteRemoteCacheManager.initRemoteCache(org.infinispan.client.hotrod.impl.RemoteCacheImpl,org.infinispan.client.hotrod.impl.operations.OperationsFactory)
2020-07-28T15:55:18.6199344Z com.oracle.svm.core.util.UserError$UserException: could not find target method: private void io.quarkus.infinispan.client.runtime.graal.SubstituteRemoteCacheManager.initRemoteCache(org.infinispan.client.hotrod.impl.RemoteCacheImpl,org.infinispan.client.hotrod.impl.operations.OperationsFactory)
2020-07-28T15:55:18.6210591Z 	at com.oracle.svm.core.util.UserError.abort(UserError.java:68)
2020-07-28T15:55:18.6211105Z 	at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.findOriginalMethod(AnnotationSubstitutionProcessor.java:637)
2020-07-28T15:55:18.6211311Z 	at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.handleMethodInAliasClass(AnnotationSubstitutionProcessor.java:330)
2020-07-28T15:55:18.6211513Z 	at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.handleAliasClass(AnnotationSubstitutionProcessor.java:302)
2020-07-28T15:55:18.6211712Z 	at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.handleClass(AnnotationSubstitutionProcessor.java:274)
2020-07-28T15:55:18.6211904Z 	at com.oracle.svm.hosted.substitute.AnnotationSubstitutionProcessor.init(AnnotationSubstitutionProcessor.java:230)
2020-07-28T15:55:18.6212098Z 	at com.oracle.svm.hosted.NativeImageGenerator.createDeclarativeSubstitutionProcessor(NativeImageGenerator.java:908)
2020-07-28T15:55:18.6212283Z 	at com.oracle.svm.hosted.NativeImageGenerator.setupNativeImage(NativeImageGenerator.java:838)
2020-07-28T15:55:18.6212464Z 	at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:536)
2020-07-28T15:55:18.6212620Z 	at com.oracle.svm.hosted.NativeImageGenerator.lambda$run$0(NativeImageGenerator.java:451)
2020-07-28T15:55:18.6212803Z 	at java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1407)
2020-07-28T15:55:18.6213160Z 	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
2020-07-28T15:55:18.6213348Z 	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
2020-07-28T15:55:18.6213519Z 	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
2020-07-28T15:55:18.6213691Z 	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
2020-07-28T15:55:18.6213864Z 	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)
2020-07-28T15:55:18.6650838Z Error: Image build request failed with exit status 1

Could you test locally before pushing to CI? There's no point in using our scarce CI resources when a small local build could at least fix the most obvious errors.

Thanks!

@gsmet
Copy link
Member

gsmet commented Jul 28, 2020

Just to be extra clear: we don't expect you to do a full run locally. But you should at least run the tests of the affected modules.

@karesti karesti force-pushed the upgrade-infinispan-version branch from eae3e5b to 642c86a Compare July 28, 2020 23:25
@karesti
Copy link
Member Author

karesti commented Jul 28, 2020

yes sorry @gsmet I was like a happy flower confident without paying enough attention to the process. I managed to have the native test passing locally and I corrected a couple of additional things

2020-07-29 01:24:39,169 INFO  [io.qua.it.inf.cli.TestServlet] (executor-thread-1) Retrieving all IDs
Running query with custom marshaller test
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.651 s - in io.quarkus.it.infinispan.client.InfinispanClientFunctionalityInGraalITCase
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- maven-failsafe-plugin:3.0.0-M5:verify (default) @ quarkus-integration-test-infinispan-client ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:36 min
[INFO] Finished at: 2020-07-29T01:24:39+02:00
[INFO] ------------------------------------------------------------------------

@gsmet
Copy link
Member

gsmet commented Jul 29, 2020

Perfect, thanks, merging!

</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>2.10.0</version>
<version>2.11.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for another day but I don't think you need the versions here anymore. I think we used to have them because of a version conflict but it should be all good now.

@gsmet gsmet merged commit 63af920 into quarkusio:master Jul 29, 2020
@karesti karesti deleted the upgrade-infinispan-version branch July 29, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/infinispan Infinispan triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants