Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt config documentation to reference application.properties #1180

Merged
merged 2 commits into from
Mar 5, 2019

Conversation

emmanuelbernard
Copy link
Member

…rties

Also describe how to override with system and environment properties.
Remaining to be done:

  • make Ken review it to add SmallRye specific features like expansions
    etc
  • document the ability to reference a external file for runtime override
    once implemented

…rties

Also describe how to override with system and environment properties.
Remaining to be done:
* make Ken review it to add SmallRye specific features like expansions
etc
* document the ability to reference a external file for runtime override
once implemented
@emmanuelbernard
Copy link
Member Author

emmanuelbernard commented Mar 4, 2019

@kenfinnigan I added a todo in the doc file for you to document the SmallRye features above and beyond MP Config. (expansion etc). I could not find a SmallRye doc to reference. This should not block the PR though.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments. Looks good otherwise.

@gsmet gsmet changed the title Issue 200 - Adapt config documentation to reference application.prope… [DO NOT MERGE] Adapt config documentation to reference application.properties Mar 4, 2019
@gsmet gsmet changed the title [DO NOT MERGE] Adapt config documentation to reference application.properties Adapt config documentation to reference application.properties Mar 5, 2019
@gsmet gsmet merged commit 9049057 into quarkusio:master Mar 5, 2019
@stuartwdouglas stuartwdouglas added this to the 0.11.0 milestone Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants