-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus JBang project type #13004
Quarkus JBang project type #13004
Conversation
nice.
What is really missing though is jbang doesn't support BOM resolution thus no notion of platform when using jbang. thus not sure if we want to include it in codestarts just yet. |
@maxandersen TBH I really like the flat structure that jbang provides, if we start to add plus if you put it in
This is a new codestart project type completely separated from the quarkus project type, thus Maven and Gradle codestarts are not used for this.
I created this PR now because it was close to be done in my local branches and we needed an example of new codestart project type for #12522 For now, I am just adding the plain extension dependency with version, but yeah this would indeed be better with bom. I was thinking about creating a different CLI entry point Weird, it was supposed to be a draft PR, converting now.. |
78cf618
to
279754e
Compare
not sure if you realize it but jbang can use multiple source files now, currently that plus jbang eventually will have Having .java side-by-side with jbang/jbang.jar is not great either. Thus I think it fits perfectly quarkus codestarts will create a slight structure that is as simple as possible, but not simpler than that.
No, I just said |
56bcb5e
to
ecfaa48
Compare
ecfaa48
to
da91e0f
Compare
@maxandersen I changed the location to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't hurt ;) LGTM.
how do i actually test/try this from the cli/command line ?
command:
output:
tree 130 jbang-project-type . ├── src/ExampleResource.java ├── README.md ├── jbang └── jbang.cmd
running:
Todo in next PRs: