Native S2I Builder image #1358

vorburger · 2019-03-08T19:35:36Z

No description provided.

vorburger · 2019-03-08T19:38:59Z

How cool is this? (for #304)

@siamaksade @cescoffier @dmlloyd @gsmet @geoand @gastaldi

geoand · 2019-03-08T19:44:26Z

Looks great!

docker/centos-graal-maven-s2i/Dockerfile

gastaldi

LGTM. Added some minor suggestions, feel free to approve or reject them 😄

docker/centos-graal-maven-s2i/Dockerfile

Co-Authored-By: vorburger <mike@vorburger.ch>

gastaldi

LGTM

geoand · 2019-03-08T22:22:25Z

Very good stuff!

cescoffier

That's pretty cool, I've made a few comments.

docker/centos-graal-maven-s2i/Dockerfile

cescoffier · 2019-03-09T09:24:28Z

docker/centos-graal-maven-s2i/Dockerfile

+LABEL io.openshift.s2i.scripts-url="image:///usr/local/s2i" \
+ io.openshift.s2i.destination="/tmp" \
+
+ io.k8s.description="Platform for building and running Quarkus.io Native Java applications" \


The wording is not totally in line with the website - check https://github.com/quarkusio/quarkus/blob/master/docs/src/main/asciidoc/0-glossary.adoc.

I've attempted to adhere to that in an upcoming update (and raised #1377), hopefully better now.

docker/centos-graal-maven-s2i/README.md

cescoffier · 2019-03-09T09:26:09Z

docker/centos-graal-maven-s2i/README.md

+ oc new-app quarkus-native-s2i~https://github.com/quarkusio/quarkus-quickstarts --context-dir=getting-started-native --name=getting-started-native
+
+Note that GraalVM-based native build are more memory & CPU intensive than regular pure Java builds,
+and you therefore may need to increase the quota for OpenShift's S2I builder containers.


Can you give some hint about this?
I guess you can edit the build object.

I was hoping someone else would help with how exactly to do that... 😃

There now is at least some doc. Could always be further improved, but god enough for a 0.1?

docker/centos-graal-maven-s2i/s2i/assemble

docker/centos-graal-maven-s2i/s2i/run

cescoffier · 2019-03-09T09:29:20Z

BTW, how will we version the S2I, during the release process? If so how does that work?

@cescoffier

as suggested by @cescoffier during code review

vorburger · 2019-03-10T12:33:39Z

BTW, how will we version the S2I, during the release process? If so how does that work?

Not 100% sure I know what you mean, but if you are asking how we will release a container image from this Dockerfile to e.g. Quay.io (and/or Docker Hub), then that's trivial to set up (IFF you keep a single Dockerfile ... see above), and it can easily be made to "tag" such images based on the branch in this repo. Does this help?

cescoffier

A few comments

docker/centos-graal-maven-s2i/Dockerfile

cescoffier · 2019-03-18T08:44:50Z

docker/centos-graal-maven-s2i/Dockerfile

+
+ENV PATH=$PATH:"/usr/local/s2i"
+
+RUN mkdir /quarkus.io/


Really minor, but I try to about . in my directory name. What about just "quarkus"

it's now /home/quarkus OK for you?

docker/centos-graal-maven-s2i/Dockerfile

This should fix this S2I build error seen on OpenShift: build error: image "..." must specify a user that is numeric and within the range of allowed users

@Inject

* master: (167 commits) Allow for usage of @ConfigProperty on fields without the need for @Inject. Fixes quarkusio#1315. Expose all flavors (core, axle, rx) of Vert.x EventBus RestClient - passing incoming JAX-RS headers, fixes quarkusio#1017 JAX-RS body writers for Vert.x JsonObject and JsonArray Increase CI memory PathTestHelper should accept default Gradle build paths now + make sure we run the test in gradle-it Change to use ./mvnw Update opentracing guide to describe using application.properties as alternative to env vars fix npe in dev mode when source is missing in recompilation diagnostic Add the quarkus-elytron-security component in the BOM Moves the logic that handles the registration of schema class for serialization in smallrye-openapi-extension Add Maven Wrapper to generated projects [security extension] - AuthConfig only configured if IdentityManager is produced quarkusio#1522 Warning to keep H2 version as is Minor corrections to mx and git repo clone instructions. programmatic client generation for MP Rest Client, fixes quarkusio#1317 Hibernate ORM - Fix config property name in error message Camel - Use a constant for Camel root package directory Micro version updates JAX-RS Generate reflection declaration from MP OpenAPI schema definition ...

vorburger · 2019-03-18T22:56:54Z

@cescoffier I've further tested this, and (from my side) this is good for merge now.

cescoffier · 2019-03-19T08:17:05Z

Waiting for CI and will merge.

geoand · 2019-03-19T09:42:08Z

docker/centos-graal-maven-s2i/Dockerfile

+# This part is heavily inspired by ../centos-graal/Dockerfile
+FROM centos:latest
+
+ARG GRAAL_VERSION=1.0.0-rc13


In the future we would need to have a way to easily remember to update this every time we are working on updating to the latest GraalVM version

Yup, just like in a few other places where it appears.

geoand · 2019-03-19T09:42:48Z

docker/centos-graal-maven-s2i/s2i/run

+# a TODO future PRODUCTION version of this would probably want tomake it possible to
+# e.g. pass additional parameters to the executable, as does fabric8io-images/s2i's run script.
+
+${QUARKUS_HOME}/*-runner -Dquarkus.http.host=0.0.0.0


-Dquarkus.http.host=0.0.0.0 shouldn't be needed anymore since it's now the default

But is that already released, right now? I would prefer to keep this and then see it removed a while after a new release, together with more generally cleaning this up in many places where it currently still appears.

The fix is in master and will be present in the 0.12.0 release that I think @cescoffier will be doing tomorrow.
I'll leave it up to you to best decide how to handle this :)

I guess we should keep it based on this #1312 (comment)

vorburger · 2019-03-19T11:20:39Z

Waiting for CI and will merge.

@cescoffier merge?

cescoffier · 2019-03-19T17:01:12Z

Thanks!

vorburger added 2 commits March 8, 2019 20:34

add Native S2I Builder image v0.1 (quarkusio#304)

86a6c94

add 'EXPOSE 8080' to native S2I builder Dockerfile

d971989

gastaldi reviewed Mar 8, 2019

View reviewed changes

docker/centos-graal-maven-s2i/Dockerfile Outdated Show resolved Hide resolved

gastaldi approved these changes Mar 8, 2019

View reviewed changes

docker/centos-graal-maven-s2i/Dockerfile Outdated Show resolved Hide resolved

docker/centos-graal-maven-s2i/Dockerfile Outdated Show resolved Hide resolved

gastaldi and others added 2 commits March 8, 2019 22:36

Minor label spelling update docker/centos-graal-maven-s2i/Dockerfile

0f677d6

Co-Authored-By: vorburger <mike@vorburger.ch>

use better Maven DL URL in Native S2I Dockerfile

43cd78b

Co-Authored-By: vorburger <mike@vorburger.ch>

gastaldi approved these changes Mar 8, 2019

View reviewed changes

cescoffier requested changes Mar 9, 2019

View reviewed changes

vorburger added 3 commits March 10, 2019 13:27

improve graal-maven-s2i Dockerfile io.k8s.* LABELs

335cdfb

as suggested by @cescoffier during code review

move -e -B in GraalVM S2I assemble script (and multiline)

9fb4604

restructure GraalVM S2I README sections (clearer like this)

0f5d431

vorburger mentioned this pull request Mar 13, 2019

Add odo watch + quarkus:dev live reload support as one mode of the S2I #1390

Closed

cescoffier requested changes Mar 18, 2019

View reviewed changes

vorburger mentioned this pull request Mar 18, 2019

Enhance builder image with extra tools #1511

Closed

vorburger changed the title ~~add Native S2I Builder image v0.1 (#304)~~ [WIP] {NOK} add Native S2I Builder image v0.1 (#304) Mar 18, 2019

vorburger added 10 commits March 18, 2019 21:32

minor centos-graal-maven-s2i README update

2f3e547

add 'USER 1001' in centos-graal-maven-s2i/Dockerfile

326b8b8

This should fix this S2I build error seen on OpenShift: build error: image "..." must specify a user that is numeric and within the range of allowed users

use 'cp -v' in s2i/assemble

33e95b8

improve centos-graal-maven-s2i README

cb25510

bump GRAAL_VERSION rc12 to rc13

c6f093c

use ARG instead of ENV in Dockerfile

c165b1c

move add user up, and use home dir in MAVEN_CONFIG

7c14305

use /home/quarkus instead of /quarkus.io

4b550da

use ENV instead of ARG in Dockerfile where appropriate

04029d9

vorburger changed the title ~~[WIP] {NOK} add Native S2I Builder image v0.1 (#304)~~ add Native S2I Builder image v0.1 (#304) Mar 18, 2019

cescoffier approved these changes Mar 19, 2019

View reviewed changes

cescoffier changed the title ~~add Native S2I Builder image v0.1 (#304)~~ Native S2I Builder image Mar 19, 2019

cescoffier added this to the 0.12.0 milestone Mar 19, 2019

cescoffier added release/noteworthy-feature kind/enhancement New feature or request labels Mar 19, 2019

geoand reviewed Mar 19, 2019

View reviewed changes

vorburger added 2 commits March 19, 2019 14:03

update Native S2I README with testing results re. CPU limit

a05b6f3

add 'oc patch' tip to Native S2I README (tx @tqvarnst)

fafe896

cescoffier merged commit 6c7c813 into quarkusio:master Mar 19, 2019

vorburger mentioned this pull request Mar 19, 2019

Native image S2I build support #304

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Native S2I Builder image #1358

Native S2I Builder image #1358

vorburger commented Mar 8, 2019

vorburger commented Mar 8, 2019

geoand commented Mar 8, 2019

gastaldi left a comment

gastaldi left a comment

geoand commented Mar 8, 2019

cescoffier left a comment

cescoffier Mar 9, 2019

vorburger Mar 10, 2019

cescoffier Mar 9, 2019

vorburger Mar 10, 2019

vorburger Mar 18, 2019

cescoffier commented Mar 9, 2019

vorburger commented Mar 10, 2019

cescoffier left a comment

cescoffier Mar 18, 2019

vorburger Mar 18, 2019

cescoffier Mar 19, 2019

vorburger commented Mar 18, 2019

cescoffier commented Mar 19, 2019

geoand Mar 19, 2019

vorburger Mar 19, 2019

geoand Mar 19, 2019 •

edited

Loading

geoand Mar 19, 2019

vorburger Mar 19, 2019

geoand Mar 19, 2019

geoand Mar 19, 2019 •

edited

Loading

vorburger commented Mar 19, 2019

cescoffier commented Mar 19, 2019

Native S2I Builder image #1358

Native S2I Builder image #1358

Conversation

vorburger commented Mar 8, 2019

vorburger commented Mar 8, 2019

geoand commented Mar 8, 2019

gastaldi left a comment

Choose a reason for hiding this comment

gastaldi left a comment

Choose a reason for hiding this comment

geoand commented Mar 8, 2019

cescoffier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cescoffier commented Mar 9, 2019

vorburger commented Mar 10, 2019

cescoffier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vorburger commented Mar 18, 2019

cescoffier commented Mar 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geoand Mar 19, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geoand Mar 19, 2019 • edited Loading

Choose a reason for hiding this comment

vorburger commented Mar 19, 2019

cescoffier commented Mar 19, 2019

geoand Mar 19, 2019 •

edited

Loading

geoand Mar 19, 2019 •

edited

Loading